Replace ScopedThreadProxy with MessageLoopProxy & WeakPtrs.

Replace ScopedThreadProxy with MessageLoopProxy & WeakPtrs.

This affects the following classes:
* ChromotingClient
* ChromotingInstance
* HostUserInterface
* It2MeHostUserInterface

The MessageLoopProxy/WeakPtr combination requires that the WeakPtr is created on the thread referred to by the proxy; code in which that is hard to arrange usually has subtle race-conditions.

This is a re-land of CL 1045404, replacing some CR_DEFINE_STATIC_LOCAL() instances with base::LazyInstance to avoid adding global initializers or finalizers.

TEST=Existing unit-tests, and manual testing.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141028

[Wez, 2012-05-31 00:46:43]

This is an attempt to re-land http://codereview.chromium.org/10454040/ using
LazyInstance to avoid initializers and finalizers.

[Wez, 2012-06-02 00:33:38]

On 2012/05/31 00:46:43, Wez wrote:
> This is an attempt to re-land http://codereview.chromium.org/10454040/ using
> LazyInstance to avoid initializers and finalizers.

ping!

[Sergey Ulanov, 2012-06-02 00:57:44]

LGTM when my comments are addressed

http://codereview.chromium.org/10440107/diff/1/remoting/client/plugin/chromot...
File remoting/client/plugin/chromoting_instance.cc (right):

http://codereview.chromium.org/10440107/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.cc:666:
g_logging_task_runner.Get()->PostTask(
This should be logging_task_runner instead of g_logging_task_runner.

http://codereview.chromium.org/10440107/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.cc:668: g_logging_instance.Get(),
message));
should we also copy g_logging_instance with g_logging_lock locked?

[Wez, 2012-06-07 16:28:53]

http://codereview.chromium.org/10440107/diff/1/remoting/client/plugin/chromot...
File remoting/client/plugin/chromoting_instance.cc (right):

http://codereview.chromium.org/10440107/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.cc:666:
g_logging_task_runner.Get()->PostTask(
On 2012/06/02 00:57:45, sergeyu wrote:
> This should be logging_task_runner instead of g_logging_task_runner.

Done.

http://codereview.chromium.org/10440107/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.cc:668: g_logging_instance.Get(),
message));
On 2012/06/02 00:57:45, sergeyu wrote:
> should we also copy g_logging_instance with g_logging_lock locked?

Done.

[commit-bot: I haz the power, 2012-06-07 16:29:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10440107/10001

[commit-bot: I haz the power, 2012-06-07 17:40:10]

Change committed as 141028