Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 10436015: Remove chrome.windows.* support for platform apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index e60f1bc095af4e332a9b00c7eb6db08b9534d14a..3f55161e9d07f5099d2e0e49e13506d8ddf7c2cb 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -549,16 +549,6 @@ bool CreateWindowFunction::RunImpl() {
window_type = Browser::TYPE_PANEL;
else
window_type = Browser::TYPE_POPUP;
- } else if (type_str == keys::kWindowTypeValueShell &&
- GetExtension()->is_platform_app()) {
- GURL window_url = urls.empty() ? GURL(chrome::kAboutBlankURL) : urls[0];
- ShellWindow* shell_window =
- ShellWindow::Create(window_profile, GetExtension(), window_url);
- shell_window->SetBounds(window_bounds);
- shell_window->Show();
- result_.reset(shell_window->extension_window_controller()->
- CreateWindowValueWithTabs());
- return true;
} else if (type_str != keys::kWindowTypeValueNormal) {
error_ = keys::kInvalidWindowTypeError;
return false;

Powered by Google App Engine
This is Rietveld 408576698