Issue 10435003: Add support for 'nocompile' to IDL schema compiler.

Issue 10435003: Add support for 'nocompile' to IDL schema compiler. (Closed)

Created:
8 years, 7 months ago by asargent_no_longer_on_chrome

Modified:
8 years, 7 months ago

Reviewers:
miket_OOO

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, pam+watch_chromium.org, not at google - send to devlin, jeremya

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for 'nocompile' to IDL schema compiler. The json schema stuff already has this support, to skip generation of C++ code for certain functions. Doing the same thing for IDL is slightly complicated by the fact that we still want to generate JSON for functions marked nocompile. BUG=129080 TEST=includes unit and browser tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138707

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fixes, and rebased #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -10 lines)			Patch
M	chrome/browser/extensions/api/idltest/idltest_apitest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/experimental_idltest.idl	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/idltest/nocompile/manifest.json	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tools/json_schema_compiler/compiler.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/idl_schema.py	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	tools/json_schema_compiler/idl_schema_test.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/json_schema_compiler/json_schema.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/json_schema_compiler/json_schema_test.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/json_schema_compiler/model.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/json_schema_compiler/schema_bundle_generator.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/json_schema_compiler/test/idl_basics.idl	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

miket_OOO

lgtm http://codereview.chromium.org/10435003/diff/1/chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js File chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js (right): http://codereview.chromium.org/10435003/diff/1/chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js#newcode1 chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js:1: Header, or at least deal with the newlines. ...

8 years, 7 months ago (2012-05-23 22:02:28 UTC) #3

asargent_no_longer_on_chrome

http://codereview.chromium.org/10435003/diff/1/chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js File chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js (right): http://codereview.chromium.org/10435003/diff/1/chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js#newcode1 chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js:1: On 2012/05/23 22:02:28, miket wrote: > Header, or at ...

8 years, 7 months ago (2012-05-23 22:21:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10435003/7001

8 years, 7 months ago (2012-05-23 22:22:54 UTC) #5

Change committed as 138707

Expand Messages | Collapse Messages