Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: src/heap-inl.h

Issue 1043001: Fix bad use of OffsetFrom that fails on ARM (sizeof(Object) wasn't 1). (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap-inl.h
diff --git a/src/heap-inl.h b/src/heap-inl.h
index 1acdb2a081be9e6196ac99c991c7a0fa0aa3fee0..5349be7ab6d9d753254e31442e8614fc40727727 100644
--- a/src/heap-inl.h
+++ b/src/heap-inl.h
@@ -133,7 +133,8 @@ Object* Heap::AllocateRawMap() {
#ifdef DEBUG
if (!result->IsFailure()) {
// Maps have their own alignment.
- CHECK((OffsetFrom(result) & kMapAlignmentMask) == kHeapObjectTag);
+ CHECK_EQ(static_cast<intptr_t>(kHeapObjectTag),
+ reinterpret_cast<intptr_t>(result) & kMapAlignmentMask);
}
#endif
return result;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698