Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Unified Diff: src/runtime.cc

Issue 1042006: Revert r4146. Add a special case in Math.round for a SMI result. Also change ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
===================================================================
--- src/runtime.cc (revision 4155)
+++ src/runtime.cc (working copy)
@@ -5325,21 +5325,12 @@
NoHandleAllocation ha;
ASSERT(args.length() == 1);
Counters::math_round.Increment();
- CONVERT_DOUBLE_CHECKED(x, args[0]);
- if (x > 0 && x < Smi::kMaxValue) {
- return Smi::FromInt(static_cast<int>(x + 0.5));
- }
-
+ CONVERT_DOUBLE_CHECKED(x, args[0]);
if (signbit(x) && x >= -0.5) return Heap::minus_zero_value();
-
- // if the magnitude is big enough, there's no place for fraction part. If we
- // try to add 0.5 to this number, 1.0 will be added instead.
- if (x >= 9007199254740991.0 || x <= -9007199254740991.0) {
- return args[0];
- }
-
- return Heap::NumberFromDouble(floor(x + 0.5));
+ double integer = ceil(x);
+ if (integer - x > 0.5) { integer -= 1.0; }
+ return Heap::NumberFromDouble(integer);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698