Fix TestingAutomationProvider::SimulateAsanMemoryBug.

chrome/browser/automation/testing_automation_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 5867 matching lines @@
   base::Closure reply =
       base::Bind(SendSuccessReply, AsWeakPtr(), reply_message);
   g_browser_process->policy_service()->RefreshPolicies(
       base::Bind(PostTask, BrowserThread::IO,
           base::Bind(PostTask, BrowserThread::FILE,
               base::Bind(PostTask, BrowserThread::IO,
                   base::Bind(PostTask, BrowserThread::UI, reply)))));
 #endif
 }
 
-static int AccessArray(const int arr[], int index) {
+static int AccessArray(const volatile int arr[], int index) {
   return arr[index];
 }
 
 void TestingAutomationProvider::SimulateAsanMemoryBug(
     base::DictionaryValue* args, IPC::Message* reply_message) {
-  int testarray[41];
+  volatile int testarray[41];

[Nirnimesh, 2012/05/22 16:29:43]

please make a note here why it's volatile.

+  AutomationJSONReply(this, reply_message).SendSuccess(NULL);

[Nirnimesh, 2012/05/22 16:29:43]

Most pyauto automation hooks return _after_ they've done their job. Since this
is not in that league, please make a note of this in SimulateAsanMemoryBug's
docstring in pyauto.py. Something like:
This returns immediately before it actually causes a crash.

   AccessArray(testarray, 42);
-  AutomationJSONReply(this, reply_message).SendSuccess(NULL);
 }
 
 void TestingAutomationProvider::GetIndicesFromTab(
     DictionaryValue* args,
     IPC::Message* reply_message) {
   AutomationJSONReply reply(this, reply_message);
   int id_or_handle = 0;
   bool has_id = args->HasKey("tab_id");
   bool has_handle = args->HasKey("tab_handle");
   if (has_id && has_handle) {
@@ skipping 657 matching lines @@
 
 void TestingAutomationProvider::WaitForProcessLauncherThreadToGoIdle(
     IPC::Message* reply_message) {
   new WaitForProcessLauncherThreadToGoIdleObserver(this, reply_message);
 }
 
 void TestingAutomationProvider::OnRemoveProvider() {
   if (g_browser_process)
     g_browser_process->GetAutomationProviderList()->RemoveProvider(this);
 }