Run Crankshaft on a separate thread.

src/v8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 13 matching lines @@
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include "v8.h"
 
 #include "assembler.h"
 #include "isolate.h"
 #include "elements.h"
 #include "bootstrapper.h"
+#include "crankshaft-thread.h"
 #include "debug.h"
 #include "deoptimizer.h"
 #include "frames.h"
 #include "heap-profiler.h"
 #include "hydrogen.h"
 #include "lithium-allocator.h"
 #include "log.h"
 #include "once.h"
 #include "platform.h"
 #include "runtime-profiler.h"
@@ skipping 55 matching lines @@
   has_fatal_error_ = true;
 }
 
 
 void V8::TearDown() {
   Isolate* isolate = Isolate::Current();
   ASSERT(isolate->IsDefaultIsolate());
 
   if (!has_been_set_up_ || has_been_disposed_) return;
 
-  ElementsAccessor::TearDown();
-  LOperand::TearDownCaches();
-  RegisteredExtension::UnregisterAll();
-
-  isolate->TearDown();
-  delete isolate;
+  if (FLAG_concurrent_crankshaft) {
+    // Lock only when required.
+    bool to_lock = !isolate->thread_manager()->IsLockedByCurrentThread();
+    if (to_lock)
+      isolate->thread_manager()->Lock();
+    isolate->TearDown();
+    // The crankshaft thread will tear down ElementsAccessor, LOperand
+    // and RegisteredExtension once it is safe to do so.
+    if (to_lock)
+      isolate->thread_manager()->Unlock();
+    CrankshaftThread::StopThread();
+  } else {
+    ElementsAccessor::TearDown();

[danno, 2012/05/22 10:32:19]

Yikes, this tear down work should always happen here, even when the crankshaft
thread is active... even if it requires some sort of synchronization.

+    LOperand::TearDownCaches();
+    RegisteredExtension::UnregisterAll();
+    isolate->TearDown();
+    delete isolate;
+  }
 
   is_running_ = false;
   has_been_disposed_ = true;
 
   delete call_completed_callbacks_;
   call_completed_callbacks_ = NULL;
 
   OS::TearDown();
 }
 
@@ skipping 120 matching lines @@
   r.uint64_t_value |= random_bits;
   r.double_value -= binary_million;
 
   HeapNumber::cast(heap_number)->set_value(r.double_value);
   return heap_number;
 }
 
 void V8::InitializeOncePerProcessImpl() {
   OS::SetUp();
 
+  if (i::FLAG_concurrent_crankshaft)

[danno, 2012/05/22 10:32:19]

nit: Always use { } even around single line statements:

if (i::FLAG_concurrent_crankshaft) {
  i::CrankshaftThread::StartThread();
}

+    i::CrankshaftThread::StartThread();
+
   use_crankshaft_ = FLAG_crankshaft;
 
   if (Serializer::enabled()) {
     use_crankshaft_ = false;
   }
 
   CPU::SetUp();
   if (!CPU::SupportsCrankshaft()) {
     use_crankshaft_ = false;
   }
@@ skipping 14 matching lines @@
   SetUpJSCallerSavedCodeData();
   SamplerRegistry::SetUp();
   ExternalReference::SetUp();
 }
 
 void V8::InitializeOncePerProcess() {
   CallOnce(&init_once, &InitializeOncePerProcessImpl);
 }
 
 } }  // namespace v8::internal