Issue 10416047: Fix build with system zlib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10416047: Fix build with system zlib. (Closed)

Created:
8 years, 7 months ago by Paweł Hajdan Jr.

Modified:
8 years, 6 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix build with system zlib. This adds a missing dependency on zlib.gyp, so that USE_SYSTEM_ZLIB pre-processor symbol is defined when using system zlib. This is upstreaming a Gentoo Linux patch. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139225

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/chrome_browser.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/10416047/1

8 years, 7 months ago (2012-05-22 20:26:06 UTC) #3

commit-bot: I haz the power

Try job failure for 10416047-1 (retry) on win_rel for step "runhooks". It's a second try, ...

8 years, 7 months ago (2012-05-22 23:33:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/10416047/1

8 years, 7 months ago (2012-05-23 05:41:11 UTC) #5

commit-bot: I haz the power

8 years, 7 months ago (2012-05-23 12:26:58 UTC) #6

Try job failure for 10416047-1 (retry) (retry) on win_rel for step
"sync_unit_tests".
It's a second try, previously, step "sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages