RefCounted types should not have public destructors

content/public/common/resource_response.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #ifndef CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_
 #define CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_
 #pragma once
 
@@ skipping 21 matching lines @@
 // Parameters for a synchronous resource response.
 struct SyncLoadResult : ResourceResponseHead {
   // The final URL after any redirects.
   GURL final_url;
 
   // The response data.
   std::string data;
 };
 
 // Simple wrapper that refcounts ResourceResponseHead.
-struct CONTENT_EXPORT ResourceResponse
-    : public NON_EXPORTED_BASE(ResourceResponseHead),
-      public base::RefCounted<ResourceResponse> {
-
- private:
-  friend class base::RefCounted<ResourceResponse>;
-
+// Inherited, rather than typedef'd, to allow forward declarations.
+class CONTENT_EXPORT ResourceResponse

[jam, 2012/05/21 15:18:43]

please keep this as a struct. for the content api, we only want either structs
or classes that are intefaces in the public dir

[darin (slow to review), 2012/05/22 18:01:31]

+1

This should be a struct.  What problem was the old code causing?

+    : public base::RefCountedData<ResourceResponseHead> {
+ protected:
   ~ResourceResponse() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_