Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Unified Diff: ash/accelerators/accelerator_controller_unittest.cc

Issue 10414064: Handle more browser commands in ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/accelerator_controller_unittest.cc
diff --git a/ash/accelerators/accelerator_controller_unittest.cc b/ash/accelerators/accelerator_controller_unittest.cc
index 54b6f827d4274e2e024a7e53dcafe1c50d7899f8..475d007c2b87cfdd1d7afdb841d2f12126168d51 100644
--- a/ash/accelerators/accelerator_controller_unittest.cc
+++ b/ash/accelerators/accelerator_controller_unittest.cc
@@ -649,6 +649,10 @@ TEST_F(AcceleratorControllerTest, DISABLED_GlobalAccelerators) {
EXPECT_TRUE(GetController()->Process(
ui::Accelerator(ui::VKEY_Q, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
+ // New tab
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_T, ui::EF_SHIFT_DOWN)));
+
// New incognito window
EXPECT_TRUE(GetController()->Process(
ui::Accelerator(ui::VKEY_N, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
@@ -661,6 +665,37 @@ TEST_F(AcceleratorControllerTest, DISABLED_GlobalAccelerators) {
EXPECT_TRUE(GetController()->Process(
ui::Accelerator(ui::VKEY_L, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
#endif
+
+ // Open bookmark manager
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_O, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
+
+ // Clear browsing data
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_BACK, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
+
+ // Open downloads page
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_J, ui::EF_CONTROL_DOWN)));
+
+ // Open help page
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_OEM_2, ui::EF_CONTROL_DOWN)));
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_OEM_2,
+ ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
+
+ // Open history page
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_H, ui::EF_CONTROL_DOWN)));
+
+ // Restore tab
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_T, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
+
+ // Show task manager
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_SHIFT_DOWN)));
}
TEST_F(AcceleratorControllerTest, ImeGlobalAccelerators) {

Powered by Google App Engine
This is Rietveld 408576698