Issue 10414035: Move TransferNavigationResourceThrottle to content since that's where it belongs. This is a step in…

Issue 10414035: Move TransferNavigationResourceThrottle to content since that's where it belongs. This is a step in… (Closed)

Created:
8 years, 7 months ago by jam

Modified:
8 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, joi+watch-content_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move TransferNavigationResourceThrottle to content since that's where it belongs. This is a step in getting rid of RenderViewHostDelegate usage in chrome, so that we can hide it. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138251

Patch Set 1 : #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : review comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -226 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
D	chrome/browser/renderer_host/transfer_navigation_resource_throttle.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome/browser/renderer_host/transfer_navigation_resource_throttle.cc	View		1 chunk	+0 lines, -94 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/mock_content_browser_client.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_impl.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_impl.cc	View	1 2	6 chunks	+34 lines, -27 lines	0 comments	Download
A +	content/browser/renderer_host/transfer_navigation_resource_throttle.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
A +	content/browser/renderer_host/transfer_navigation_resource_throttle.cc	View		4 chunks	+7 lines, -13 lines	0 comments	Download
M	content/content_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View		17 chunks	+35 lines, -34 lines	0 comments	Download
M	content/public/browser/resource_dispatcher_host.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/public/browser/resource_dispatcher_host_delegate.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	content/shell/shell_content_browser_client.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	content/shell/shell_content_browser_client.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM http://codereview.chromium.org/10414035/diff/8004/content/browser/renderer_host/resource_dispatcher_host_impl.cc File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right): http://codereview.chromium.org/10414035/diff/8004/content/browser/renderer_host/resource_dispatcher_host_impl.cc#newcode556 content/browser/renderer_host/resource_dispatcher_host_impl.cc:556: void ResourceDispatcherHostImpl::MarkAsTransferredNavigation( nit: move to after WillSendData so ...

8 years, 7 months ago (2012-05-22 05:23:06 UTC) #2

jam

http://codereview.chromium.org/10414035/diff/8004/content/browser/renderer_host/resource_dispatcher_host_impl.cc File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right): http://codereview.chromium.org/10414035/diff/8004/content/browser/renderer_host/resource_dispatcher_host_impl.cc#newcode556 content/browser/renderer_host/resource_dispatcher_host_impl.cc:556: void ResourceDispatcherHostImpl::MarkAsTransferredNavigation( On 2012/05/22 05:23:06, darin wrote: > nit: ...

8 years, 7 months ago (2012-05-22 15:01:35 UTC) #3

LGTM

Expand Messages | Collapse Messages