Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 10413: Add platform_utils and stub test lists for Linux. (Closed)

Created:
12 years, 1 month ago by Michael Moss
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add platform_utils and stub test lists for Linux. This allows the LayoutTest harness to run on Linux. Note that the tests still don't run properly because Linux test_shell is missing the ability to read URLs from stdin (causing the test_shell to just sit there waiting for input). I'll add that in another CL. BUG=4281

Patch Set 1 #

Patch Set 2 : Add method to support test rearranging. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -3 lines) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/layout_tests/layout_package/platform_utils.py View 1 chunk +2 lines, -2 lines 0 comments Download
A webkit/tools/layout_tests/layout_package/platform_utils_linux.py View 1 1 chunk +145 lines, -0 lines 0 comments Download
A webkit/tools/layout_tests/test_lists/linux/tests_fixable.txt View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/tools/layout_tests/test_lists/linux/tests_ignored.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Moss
12 years, 1 month ago (2008-11-13 18:05:32 UTC) #1
pink (ping after 24hrs)
LGTM, though I'm no python expert.
12 years, 1 month ago (2008-11-13 18:24:45 UTC) #2
tony
LGTM In the long run, it would probably be nice if we could have a ...
12 years, 1 month ago (2008-11-13 18:46:39 UTC) #3
Elliot Glaysher
After Pam's recent changes to how everything works, you're going to have to add something ...
12 years, 1 month ago (2008-11-14 01:06:17 UTC) #4
Pam (message me for reviews)
On 2008/11/13 18:46:39, tony wrote: > LGTM > > In the long run, it would ...
12 years, 1 month ago (2008-11-14 01:17:02 UTC) #5
Michael Moss
> def PlatformDir(self): Done.
12 years, 1 month ago (2008-11-17 18:37:46 UTC) #6
tony
12 years, 1 month ago (2008-11-17 19:20:14 UTC) #7
LG

Powered by Google App Engine
This is Rietveld 408576698