Fix crashes in DownloadRequestLimiter when extension popups/bubbles initiate downloads automatically

chrome/browser/extensions/extension_host.cc

Index: chrome/browser/extensions/extension_host.cc
diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc
index f72fbcedf017fec80ea738f429393547eb3d800f..f8126480dad12594316db3ed7cde71440895b5a3 100644
--- a/chrome/browser/extensions/extension_host.cc
+++ b/chrome/browser/extensions/extension_host.cc
@@ -59,6 +59,7 @@
 
 using WebKit::WebDragOperation;
 using WebKit::WebDragOperationsMask;
+using content::DownloadItem;
 using content::NativeWebKeyboardEvent;
 using content::OpenURLParams;
 using content::RenderViewHost;
@@ -410,6 +411,17 @@ void ExtensionHost::CloseContents(WebContents* contents) {
   }
 }
 
+void ExtensionHost::OnStartDownload(
+    WebContents* source, DownloadItem* download) {
+  Profile* profile = Profile::FromBrowserContext(source->GetBrowserContext());
+  Browser* browser = browser::FindTabbedBrowser(
+      profile, false);  // Match incognito exactly.

[Ben Goodger (Google), 2012/05/29 18:23:48]

So, this pattern is effectively equivalent to BrowserList::GetLastActive() and
you shouldn't be doing this.

The ExtensionHost should (and may already) carry some state that allows proper
context to be obtained safely.

+  if (!browser && view())
+    browser = view()->browser();
+  if (browser)
+    browser->OnStartDownload(source, download);
+}
+
 void ExtensionHost::WillRunJavaScriptDialog() {
   ExtensionProcessManager* pm =
       ExtensionSystem::Get(profile_)->process_manager();