chrome/browser/ui/tab_contents/tab_contents_wrapper.cc - Issue 10412061: Fix crashes in DownloadRequestLimiter when extension popups/bubbles initiate downloads automatically

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

Issue 10412061: Fix crashes in DownloadRequestLimiter when extension popups/bubbles initiate downloads automatically (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_request_limiter_unittest.cc ('K') | « chrome/browser/ui/tab_contents/tab_contents_wrapper.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

diff --git a/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc b/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

index f299f71821bb17a14c41cc96813f927482d58dbc..81dca1175e69b931643432e5b0ccd49aef0da4ba 100644

--- a/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

+++ b/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

@@ -11,7 +11,6 @@

#include "chrome/browser/autofill/autofill_manager.h"

#include "chrome/browser/automation/automation_tab_helper.h"

#include "chrome/browser/content_settings/tab_specific_content_settings.h"

-#include "chrome/browser/download/download_request_limiter_observer.h"

#include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h"

#include "chrome/browser/extensions/extension_tab_helper.h"

#include "chrome/browser/external_protocol/external_protocol_observer.h"

@@ -120,8 +119,6 @@ TabContentsWrapper::TabContentsWrapper(WebContents* contents)

// Create the per-tab observers.

alternate_error_page_tab_observer_.reset(

new AlternateErrorPageTabObserver(contents, profile()));

- download_request_limiter_observer_.reset(

- new DownloadRequestLimiterObserver(contents));

webnavigation_observer_.reset(

new extensions::WebNavigationTabObserver(contents));

external_protocol_observer_.reset(new ExternalProtocolObserver(contents));