chrome/browser/extensions/extension_host.h - Issue 10412061: Fix crashes in DownloadRequestLimiter when extension popups/bubbles initiate downloads automatically

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_host.h

Issue 10412061: Fix crashes in DownloadRequestLimiter when extension popups/bubbles initiate downloads automatically (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_request_limiter_unittest.cc ('K') | « chrome/browser/download/download_request_limiter_unittest.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_host.h

diff --git a/chrome/browser/extensions/extension_host.h b/chrome/browser/extensions/extension_host.h

index 56d5816419a99abb51cd443ea8d191926822d4c1..09e53ee7259fa26707ee3a6ee16a5ab00c18f453 100644

--- a/chrome/browser/extensions/extension_host.h

+++ b/chrome/browser/extensions/extension_host.h

@@ -35,6 +35,7 @@ class ExtensionWindowController;

class PrefsTabHelper;

namespace content {

+class DownloadItem;

class RenderProcessHost;

class RenderWidgetHostView;

class SiteInstance;

@@ -163,6 +164,9 @@ class ExtensionHost : public content::WebContentsDelegate,

const gfx::Rect& initial_pos,

bool user_gesture) OVERRIDE;

virtual void CloseContents(content::WebContents* contents) OVERRIDE;

+ virtual void OnStartDownload(

+ content::WebContents* source,

+ content::DownloadItem* download) OVERRIDE;

// content::NotificationObserver

virtual void Observe(int type,