chrome/browser/ui/views/browser_actions_container.h - Issue 10412052: Pull browser action click logic into ToolbarModelController, so that when I

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_actions_container.h

Issue 10412052: Pull browser action click logic into ToolbarModelController, so that when I (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: views changes Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_toolbar_model.cc ('K') | « chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/browser_actions_container.h

diff --git a/chrome/browser/ui/views/browser_actions_container.h b/chrome/browser/ui/views/browser_actions_container.h

index b88c6a98b97e43ef6ad013abc2db88face783f94..dea45749973d10ca525d599205ba557bdcd43e56 100644

--- a/chrome/browser/ui/views/browser_actions_container.h

+++ b/chrome/browser/ui/views/browser_actions_container.h

@@ -370,6 +370,9 @@ class BrowserActionsContainer

// Moves a browser action with |id| to |new_index|.

void MoveBrowserAction(const std::string& extension_id, size_t new_index);

+ // Show a popup.

+ void ShowPopup(BrowserActionButton* button, const GURL& popup_url);

Yoyo Zhou 2012/05/24 00:55:26 Does this need to be public?

not at google - send to devlin 2012/05/25 00:55:40 Nope. Thanks, made private (I put it here to be al

// Hide the current popup.

void HidePopup();