Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4196)

Unified Diff: chrome/browser/chromeos/cros/cros_network_functions.cc

Issue 10412026: This fixes static IP setting on Ethernet when using flimflam. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed switch statement Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/network_ip_config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/cros_network_functions.cc
diff --git a/chrome/browser/chromeos/cros/cros_network_functions.cc b/chrome/browser/chromeos/cros/cros_network_functions.cc
index bb5f8c2e944e2f010427cdd679597651197050a9..0068c4919a0768ecdf6fa3e1f55532d6a5fbf656 100644
--- a/chrome/browser/chromeos/cros/cros_network_functions.cc
+++ b/chrome/browser/chromeos/cros/cros_network_functions.cc
@@ -1064,7 +1064,8 @@ bool CrosAddIPConfig(const std::string& device_path, IPConfigType type) {
DBusThreadManager::Get()->GetFlimflamDeviceClient()->
CallAddIPConfigAndBlock(dbus::ObjectPath(device_path), type_str);
if (result.value().empty()) {
- LOG(WARNING) <<"Add IPConfig failed: ";
+ LOG(ERROR) << "Add IPConfig failed for device path " << device_path
+ << " and type " << type_str;
satorux1 2012/05/22 00:43:07 << should be vertically aligned.
Greg Spencer (Chromium) 2012/05/22 00:44:54 Done.
return false;
}
return true;
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/network_ip_config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698