This fixes static IP setting on Ethernet when using flimflam.

This fixes static IP setting on Ethernet when using flimflam.

The main fix here is to use the ipconfig_static_path instead of
ipconfig->device_path when setting the parameters.

Also added some logging and cleaned up error messages.

Note that this only fixes static IP setting when flimflam is
enabled: this code doesn't properly talk to shill for that
operation because it still tries to create IPConfigs, which
shill doesn't implement.

BUG=chromium-os:29050
TEST=Ran on device, configured ethernet for static IP, and verified
     that it showed up in the flimflam profile.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138233

[Greg Spencer (Chromium), 2012-05-21 23:54:11]

Steven, could you review this please?  This needs to be backported to R19...

[stevenjb, 2012-05-21 23:59:46]

lgtm

http://codereview.chromium.org/10412026/diff/1/chrome/browser/chromeos/cros/n...
File chrome/browser/chromeos/cros/network_ip_config.cc (right):

http://codereview.chromium.org/10412026/diff/1/chrome/browser/chromeos/cros/n...
chrome/browser/chromeos/cros/network_ip_config.cc:23: }
Doesn't this need a NOTREACHED() + return std::string() ?

[satorux1, 2012-05-22 00:43:07]

+hashimoto. this could be related to the crash issue you were looking?

http://codereview.chromium.org/10412026/diff/4002/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/cros_network_functions.cc (right):

http://codereview.chromium.org/10412026/diff/4002/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/cros_network_functions.cc:1068: << " and type " <<
type_str;
<< should be vertically aligned.

[Greg Spencer (Chromium), 2012-05-22 00:44:54]

http://codereview.chromium.org/10412026/diff/4002/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/cros_network_functions.cc (right):

http://codereview.chromium.org/10412026/diff/4002/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/cros_network_functions.cc:1068: << " and type " <<
type_str;
On 2012/05/22 00:43:07, satorux1 wrote:
> << should be vertically aligned.

Done.

[Greg Spencer (Chromium), 2012-05-22 00:45:14]

http://codereview.chromium.org/10412026/diff/1/chrome/browser/chromeos/cros/n...
File chrome/browser/chromeos/cros/network_ip_config.cc (right):

http://codereview.chromium.org/10412026/diff/1/chrome/browser/chromeos/cros/n...
chrome/browser/chromeos/cros/network_ip_config.cc:23: }
On 2012/05/21 23:59:46, stevenjb (chromium) wrote:
> Doesn't this need a NOTREACHED() + return std::string() ?

Done.

[commit-bot: I haz the power, 2012-05-22 01:15:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10412026/8001

[commit-bot: I haz the power, 2012-05-22 05:33:24]

Try job failure for 10412026-8001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-22 07:17:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10412026/8001