content/common/gpu/media/h264_parser.cc - Issue 10411085: Build AVC decoder configuration record

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/h264_parser.cc

Issue 10411085: Build AVC decoder configuration record (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/h264_parser.cc

diff --git a/content/common/gpu/media/h264_parser.cc b/content/common/gpu/media/h264_parser.cc

index 6e3712ef7ad5417a984200c2fa9d2223be305e28..7c2fb50b91594cbd706e42d4ae6b01cac89268a8 100644

--- a/content/common/gpu/media/h264_parser.cc

+++ b/content/common/gpu/media/h264_parser.cc

@@ -657,8 +657,8 @@ H264Parser::Result H264Parser::ParseSPS(int* sps_id) {

scoped_ptr<H264SPS> sps(new H264SPS());

READ_BITS_OR_RETURN(8, &sps->profile_idc);

- // Skip constraint_setx_flag and reserved flags.

- READ_BITS_OR_RETURN(8, &data);

+ READ_BITS_OR_RETURN(4, &sps->constraint_setx_flag);

+ READ_BITS_OR_RETURN(4, &data);

Pawel Osciak 2012/06/03 17:33:22 In my version of the spec it's 6 bits of flags, no

sail 2012/06/04 14:57:02 Done.

READ_BITS_OR_RETURN(8, &sps->level_idc);

READ_UE_OR_RETURN(&sps->seq_parameter_set_id);

TRUE_OR_RETURN(sps->seq_parameter_set_id < 32);