chrome/app/breakpad_win.h - Issue 10411059: Don't pass class types across EXE/DLL boundaries for SetCommandLine() and SetExperimentList().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/breakpad_win.h

Issue 10411059: Don't pass class types across EXE/DLL boundaries for SetCommandLine() and SetExperimentList(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix typos Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_APP_BREAKPAD_WIN_H_	5 #ifndef CHROME_APP_BREAKPAD_WIN_H_

6 #define CHROME_APP_BREAKPAD_WIN_H_	6 #define CHROME_APP_BREAKPAD_WIN_H_

7 #pragma once	7 #pragma once

8	8

9 #include <windows.h>	9 #include <windows.h>

10 #include <string>	10 #include <string>

(...skipping 24 matching lines...) Expand all Loading...
35 void InitCrashReporter();	35 void InitCrashReporter();

36	36

37 // Intercepts a crash but does not process it, just ask if we want to restart	37 // Intercepts a crash but does not process it, just ask if we want to restart

38 // the browser or not.	38 // the browser or not.

39 void InitDefaultCrashCallback(LPTOP_LEVEL_EXCEPTION_FILTER filter);	39 void InitDefaultCrashCallback(LPTOP_LEVEL_EXCEPTION_FILTER filter);

40	40

41 // If chrome has been restarted because it crashed, this function will display	41 // If chrome has been restarted because it crashed, this function will display

42 // a dialog asking for permission to continue execution or to exit now.	42 // a dialog asking for permission to continue execution or to exit now.

43 bool ShowRestartDialogIfCrashed(bool* exit_now);	43 bool ShowRestartDialogIfCrashed(bool* exit_now);

44	44

	45 // Helper to convert a vector of wstrings to corresponding vector of cstrings.
	MAD 2012/05/22 14:30:49 Please add a comment that the cstrings vector can' Please add a comment that the cstrings vector can't outlive wstrings... eroman 2012/05/22 20:33:29 Done. Show quoted text On 2012/05/22 14:30:49, MAD wrote: > Please add a comment that the cstrings vector can't outlive wstrings... Done.
	46 void StringVectorToCStringVector(const std::vector<std::wstring>& wstrings,

	47 std::vector<const wchar_t> cstrings);

	48

45 namespace testing {	49 namespace testing {

46	50

47 // Testing entry point for calling a function from the unnamed namespace.	51 // Testing entry point for calling a function from the unnamed namespace.

48 void InitCustomInfoEntries();	52 void InitCustomInfoEntries();

49	53

50 }	54 }

51	55

52 #endif // CHROME_APP_BREAKPAD_WIN_H_	56 #endif // CHROME_APP_BREAKPAD_WIN_H_

OLD	NEW

« no previous file with comments | « chrome/app/breakpad_field_trial_win.cc ('k') | chrome/app/breakpad_win.cc » ('j') | no next file with comments »