Type profiler by intercepting 'new' and 'delete' expressions.

third_party/tcmalloc/chromium/src/allocated_type_map.cc

Index: third_party/tcmalloc/chromium/src/allocated_type_map.cc
diff --git a/third_party/tcmalloc/chromium/src/allocated_type_map.cc b/third_party/tcmalloc/chromium/src/allocated_type_map.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ea5c41beb7edf972d8563cdd41d9579aa3bca7ac
--- /dev/null
+++ b/third_party/tcmalloc/chromium/src/allocated_type_map.cc
@@ -0,0 +1,90 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <config.h>
+
+#include <new>
+#include <typeinfo>
+
+#include <gperftools/allocated_type_map.h>
+
+#include "addressmap-inl.h"
+#include "base/logging.h"
+#include "base/low_level_alloc.h"
+#include "base/spinlock.h"
+#include "tcmalloc_guard.h"
+
+
+//----------------------------------------------------------------------
+// Locking
+//----------------------------------------------------------------------
+
+static SpinLock g_allocated_type_lock(SpinLock::LINKER_INITIALIZED);
+
+//----------------------------------------------------------------------
+// Simple allocator for allocated type map's internal memory
+//----------------------------------------------------------------------
+
+static LowLevelAlloc::Arena* g_allocated_type_map_memory = NULL;
+
+static void* AllocatedTypeMalloc(size_t bytes) {
+  return LowLevelAlloc::AllocWithArena(bytes, g_allocated_type_map_memory);
+}
+
+static void AllocatedTypeFree(void* p) {
+  LowLevelAlloc::Free(p);
+}
+
+//----------------------------------------------------------------------
+// Profiling control/state data
+//----------------------------------------------------------------------
+
+static AddressMap<AllocatedObject>* g_allocated_type_map = NULL;
+
+//----------------------------------------------------------------------
+// Manage allocated type map
+//----------------------------------------------------------------------
+
+static void InitializeAllocatedTypeMemory() {
+  if (g_allocated_type_map_memory != NULL) {
+    RAW_DCHECK(g_allocated_type_map != NULL, "AllocatedTypeMap is NULL");
+    return;
+  }
+
+  g_allocated_type_map_memory =
+      LowLevelAlloc::NewArena(0, LowLevelAlloc::DefaultArena());
+
+  g_allocated_type_map =
+      new(AllocatedTypeMalloc(sizeof(AddressMap<AllocatedObject>)))
+          AddressMap<AllocatedObject>(AllocatedTypeMalloc, AllocatedTypeFree);
+}
+
+void InsertAllocatedType(void* address,
+                         unsigned int size,
+                         const std::type_info& type) {
+  SpinLockHolder l(&g_allocated_type_lock);

[jar (doing other things), 2012/08/23 19:55:25]

nit: don't use one letter variable names like "l".

[Dai Mikurube (NOT FULLTIME), 2012/08/24 02:47:27]

Done.  (It's very common in tcmalloc...)

[jar (doing other things), 2012/08/27 17:17:12]

TCMalloc, and other third party code, is generally not complaint with Google
readability, nor Chromium readability.

Please try to comply with Chromium readability when writing chromium code.  This
file is not a branched version of any TCMalloc code, so there is no reason to
deviate from our standards.

On 2012/08/24 02:47:27, Dai Mikurube wrote:

[Dai Mikurube (NOT FULLTIME), 2012/08/28 09:04:57]

Ok.

+  InitializeAllocatedTypeMemory();
+
+  g_allocated_type_map->Insert(address, AllocatedObject(size, &type));
+}
+
+void EraseAllocatedType(void* address) {
+  SpinLockHolder l(&g_allocated_type_lock);
+  InitializeAllocatedTypeMemory();
+
+  AllocatedObject obj;
+  g_allocated_type_map->FindAndRemove(address, &obj);
+}
+
+const std::type_info* LookupAllocatedType(const void* address) {
+  SpinLockHolder l(&g_allocated_type_lock);
+  InitializeAllocatedTypeMemory();
+
+  const AllocatedObject* found = g_allocated_type_map->Find(address);
+  if (found == NULL)
+    return NULL;
+  return found->type;
+}
+
+static const TCMallocGuard tcmalloc_initializer;

[jar (doing other things), 2012/08/23 19:55:25]

Please move to the top of the file, per suggestion in header file.  Please add
comment: 
// Ensure that TCMalloc has been initialized before static constructors are run.

[Dai Mikurube (NOT FULLTIME), 2012/08/24 02:47:27]

Done.