Type profiler by intercepting 'new' and 'delete' expressions.

base/allocator/allocated_type_control.h

Index: base/allocator/allocated_type_control.h
diff --git a/base/allocator/allocated_type_control.h b/base/allocator/allocated_type_control.h
new file mode 100644
index 0000000000000000000000000000000000000000..9b89a505cc5954000d9b865ae43af3502539af00
--- /dev/null
+++ b/base/allocator/allocated_type_control.h
@@ -0,0 +1,11 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_ALLOCATOR_ALLOCATED_TYPE_CONTROL_H_
+#define BASE_ALLOCATOR_ALLOCATED_TYPE_CONTROL_H_
+
+void StopAllocatedTypeIntercept();

[jar (doing other things), 2012/08/08 23:21:04]

Please put these in a namespace to avoid global pollution.

Given that the allocated_type.h only has two functions, and this file only has
two functions (that control the latter), I think you should put both in a single
header file, with the corresponding code in a single CC file.

[Dai Mikurube (NOT FULLTIME), 2012/08/09 10:23:54]

Put them in a namespace.


I separated them since it is a little confusing in turning on/off this
allocated_type feature.

* These two functions should be declared in "a very part of files" of "all build
cases".  It is good to declare them by "#include <...>" in some necessary files
-- e.g. process_util_posix.cc.

* __op_{new|delete}_intercept__ should be declared in "almost all the files" of
"a part of build cases with clang_use_allocated_type=1".  They should be
declared by the compiler option "-include ...".

If we merge these four functions into one file, the way to switch the
allocated_type feature gets complex.  The merged file is included by "-include"
in case of clang_use_allocated_type=1, but process_util_posix.cc should always
include it "#include".  It is hard to write a good gyp(i) files...

It is reasonable to add a guard for OS and compilers like did it in
allocated_type.h.  But, switching should be done in one place -- gyp.

+bool IsAllocatedTypeInterceptEnabled();
+
+#endif   // BASE_ALLOCATOR_ALLOCATED_TYPE_CONTROL_H_