Type profiler by intercepting 'new' and 'delete' expressions.

third_party/tcmalloc/chromium/src/allocated_type_map.cc

Index: third_party/tcmalloc/chromium/src/allocated_type_map.cc
diff --git a/third_party/tcmalloc/chromium/src/allocated_type_map.cc b/third_party/tcmalloc/chromium/src/allocated_type_map.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f603e2dab79db47f127a7e4c63f173aa50e07d18
--- /dev/null
+++ b/third_party/tcmalloc/chromium/src/allocated_type_map.cc
@@ -0,0 +1,87 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <config.h>
+
+#include <new>
+#include <typeinfo>
+
+#include <gperftools/allocated_type_map.h>
+
+#include "addressmap-inl.h"
+#include "tcmalloc_guard.h"
+#include "base/spinlock.h"
+#include "base/low_level_alloc.h"

[jar (doing other things), 2012/08/04 01:13:47]

As per comment by Ptapenko: Please alphabetize header names.

[Dai Mikurube (NOT FULLTIME), 2012/08/07 10:39:18]

Done.

+
+
+//----------------------------------------------------------------------
+// Locking
+//----------------------------------------------------------------------
+
+static SpinLock allocated_type_lock(SpinLock::LINKER_INITIALIZED);
+
+//----------------------------------------------------------------------
+// Simple allocator for allocated type map's internal memory
+//----------------------------------------------------------------------
+
+static LowLevelAlloc::Arena* allocated_type_map_memory = NULL;
+
+static void* AllocatedTypeMalloc(size_t bytes) {
+  return LowLevelAlloc::AllocWithArena(bytes, allocated_type_map_memory);
+}
+static void AllocatedTypeFree(void* p) {
+  LowLevelAlloc::Free(p);
+}
+
+//----------------------------------------------------------------------
+// Profiling control/state data
+//----------------------------------------------------------------------
+
+static AddressMap<AllocatedObject>* allocated_type_map = NULL;
+
+//----------------------------------------------------------------------
+// Manage allocated type map
+//----------------------------------------------------------------------
+
+static void InitializeAllocatedTypeMemory() {
+  if (allocated_type_map_memory == NULL) {
+    allocated_type_map_memory =
+        LowLevelAlloc::NewArena(0, LowLevelAlloc::DefaultArena());
+  }
+
+  if (allocated_type_map == NULL) {
+    allocated_type_map =
+        new(AllocatedTypeMalloc(sizeof(AddressMap<AllocatedObject>)))
+            AddressMap<AllocatedObject>(AllocatedTypeMalloc, AllocatedTypeFree);
+  }
+}
+
+extern "C" void InsertAllocatedType(void* address,
+                                    unsigned int size,
+                                    const std::type_info& type) {
+  SpinLockHolder l(&allocated_type_lock);
+  InitializeAllocatedTypeMemory();
+
+  allocated_type_map->Insert(address, AllocatedObject(size, &type));
+}
+
+extern "C" void EraseAllocatedType(void* address) {
+  SpinLockHolder l(&allocated_type_lock);
+  InitializeAllocatedTypeMemory();
+
+  AllocatedObject obj;
+  allocated_type_map->FindAndRemove(address, &obj);
+}
+
+extern "C" const std::type_info* LookupAllocatedType(const void* address) {
+  SpinLockHolder l(&allocated_type_lock);

[jar (doing other things), 2012/08/04 01:13:47]

Doesn't even your specially allocator call the new notification?  ...and as a
result, does this reenter and deadlock?

Or does your notification only take place when a standard TCMalloc based
allocation takes place?  I thought you noted that you even got notifications
when a placement new was called... so it is a bit surprising that a new with
your allocator would not be notified.

[Dai Mikurube (NOT FULLTIME), 2012/08/07 10:39:18]

Due to that and some other problems, "allocator"-related packages are out of
target by the interceptors.

http://codereview.chromium.org/10411047/diff/66015/build/common.gypi (line:
2374)

+  InitializeAllocatedTypeMemory();
+
+  const AllocatedObject* found = allocated_type_map->Find(address);
+  if (found == NULL)
+    return NULL;
+  return found->type;
+}
+
+static const TCMallocGuard tcmalloc_initializer;