Type profiler by intercepting 'new' and 'delete' expressions.

base/allocator/type_profiler_control.cc

Index: base/allocator/type_profiler_control.cc
diff --git a/base/allocator/type_profiler_control.cc b/base/allocator/type_profiler_control.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1338ca5301dd6fcb35b1a95c5d06e88ae20ae75c
--- /dev/null
+++ b/base/allocator/type_profiler_control.cc
@@ -0,0 +1,29 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/allocator/type_profiler_control.h"
+
+#if defined(PROFILING_TYPE)

[jar (doing other things), 2012/08/30 16:02:10]

Ifdefs make the code hard to read.  You only need one ifdef block in this file.

Use an ifdef on only this declaration, and set it to false if the macro value
suggests that.

Don't use an ifdef to change StopProfiling (since g_enable_intercept will never
be true!).


Don't use an ifdef in IsProfiling(), since the global will indeed have the
correct value.

[Dai Mikurube (NOT FULLTIME), 2012/08/31 06:10:30]

Done.

+static int g_enable_intercept = 1;

[jar (doing other things), 2012/08/30 16:02:10]

nit: suggest using bool.

[Dai Mikurube (NOT FULLTIME), 2012/08/31 06:10:30]

Done.

+#endif
+
+namespace base {
+namespace type_profiler {
+
+void StopProfiling() {
+#if defined(PROFILING_TYPE)
+  g_enable_intercept = 0;
+#endif
+}
+
+bool IsProfiling() {
+#if defined(PROFILING_TYPE)
+  return g_enable_intercept != 0;
+#else
+  return false;
+#endif
+}
+
+}  // namespace type_profiler
+}  // namespace base