Type profiler by intercepting 'new' and 'delete' expressions.

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stdlib.h>
 
 #include "base/allocator/allocator_extension.h"
 #include "base/at_exit.h"
@@ skipping 30 matching lines @@
 #include "ipc/ipc_switches.h"
 #include "media/base/media.h"
 #include "sandbox/win/src/sandbox_types.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/base/ui_base_paths.h"
 #include "ui/base/win/dpi.h"
 #include "webkit/glue/webkit_glue.h"
 
 #if defined(USE_TCMALLOC)
 #include "third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h"
+#if defined(PROFILING_ALLOCATED_TYPE)
+#include "base/allocator/allocated_type_profiler_tcmalloc.h"
+#endif
 #endif
 
 #if defined(OS_WIN)
 #include <cstring>
 #include <atlbase.h>
 #include <atlapp.h>
 #include <malloc.h>
 #elif defined(OS_MACOSX)
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/mach_ipc_mac.h"
@@ skipping 379 matching lines @@
                          const char** argv,
                          ContentMainDelegate* delegate) OVERRIDE {
 
     // NOTE(willchan): One might ask why this call is done here rather than in
     // process_util_linux.cc with the definition of
     // EnableTerminationOnOutOfMemory().  That's because base shouldn't have a
     // dependency on TCMalloc.  Really, we ought to have our allocator shim code
     // implement this EnableTerminationOnOutOfMemory() function.  Whateverz.
     // This works for now.
 #if !defined(OS_MACOSX) && defined(USE_TCMALLOC)
+
+#if defined(PROFILING_ALLOCATED_TYPE)
+    base::allocated_type::SetNewInterceptFunction(

[jar (doing other things), 2012/08/23 19:55:25]

nit: Do you ever set these separately? IF you always set them as a pair, why not
have one function:

SetInterceptFunctions(...)

[Dai Mikurube (NOT FULLTIME), 2012/08/24 02:47:27]

Done.  I kept individual functions since I often use them locally.

[jar (doing other things), 2012/08/27 17:17:12]

It was not clear which of these should be set first, and it was not clear if it
mattered.  Using a single function allows you to encapsulate the ordering of the
sets in your module.

The individual functions should not be public, but you are free to use them as
private methods to assist in your implementation.

On 2012/08/24 02:47:27, Dai Mikurube wrote:

[Dai Mikurube (NOT FULLTIME), 2012/08/27 23:52:56]

Ok, I'll remove individual functions.  When I need individual functions locally,
I add them locally.

[Dai Mikurube (NOT FULLTIME), 2012/08/28 09:04:57]

Done.

+        base::allocated_type::NewInterceptForTCMalloc);
+    base::allocated_type::SetDeleteInterceptFunction(
+        base::allocated_type::DeleteInterceptForTCMalloc);
+#endif
+
     // For tcmalloc, we need to tell it to behave like new.
     tc_set_new_mode(1);
 
     // On windows, we've already set these thunks up in _heap_init()
     base::allocator::SetGetStatsFunction(GetStatsThunk);
     base::allocator::SetReleaseFreeMemoryFunction(ReleaseFreeMemoryThunk);
 
     // Provide optional hook for monitoring allocation quantities on a
     // per-thread basis.  Only set the hook if the environment indicates this
     // needs to be enabled.
@@ skipping 249 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content