base/allocator/allocated_type.h - Issue 10411047: Type profiler by intercepting 'new' and 'delete' expressions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/allocator/allocated_type.h

Issue 10411047: Type profiler by intercepting 'new' and 'delete' expressions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reflected the comments #17-#19. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_ALLOCATOR_ALLOCATED_TYPE_H_

	6 #define BASE_ALLOCATOR_ALLOCATED_TYPE_H_

	7

	8 #include <cstddef>

	9 #include <typeinfo>

	10

	11 // These functions are inserted around all 'new' and 'delete' expressions by
	jar (doing other things) 2012/08/08 23:21:04 Can you indicate that this is only done or Clang? Can you indicate that this is only done or Clang? (assuming I correctly understood that you only hacked that compiler). Is it possible to clarify this further by either naming the file for the platform (android?), or by surrounding the declarations in an ifdef for that platform? Dai Mikurube (NOT FULLTIME) 2012/08/09 10:23:54 Added a comment and #if defined(__linux__) && defi Show quoted text On 2012/08/08 23:21:04, jar wrote: > Can you indicate that this is only done or Clang? (assuming I correctly > understood that you only hacked that compiler). > > Is it possible to clarify this further by either naming the file for the > platform (android?), or by surrounding the declarations in an ifdef for that > platform? Added a comment and #if defined(__linux__) && defined(__clang__). I chose #if (not filename) since we can extend it easily to other platforms, e.g. Mac, though I haven't tested on other platforms.
	12 // the compiler option '-fintercept-allocation-functions' introduced in

	13 // http://crrev.com/149572.

	14

	15 void* __op_new_intercept__(void* ptr,

	16 size_t size,

	17 const std::type_info& type);

	18

	19 void* __op_delete_intercept__(void* ptr,

	20 size_t size,

	21 const std::type_info& type);

	22

	23 #endif // BASE_ALLOCATOR_ALLOCATED_TYPE_H_

OLD	NEW

« no previous file with comments | « no previous file | base/allocator/allocated_type_control.h » ('j') | base/allocator/allocated_type_control.h » ('J')