Type profiler by intercepting 'new' and 'delete' expressions.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 220 matching lines @@
       # Enable building with ASAN (Clang's -faddress-sanitizer option).
       # -faddress-sanitizer only works with clang, but asan=1 implies clang=1
       # See https://sites.google.com/a/chromium.org/dev/developers/testing/addresssanitizer
       'asan%': 0,
 
       # Enable building with TSAN (Clang's -fthread-sanitizer option).
       # -fthread-sanitizer only works with clang, but tsan=1 implies clang=1
       # See http://clang.llvm.org/docs/ThreadSanitizer.html
       'tsan%': 0,
 
+      # Use a modified version of Clang to intercept allocated types and sizes
+      # for allocated objects. -fintercept-allocated-type only works with the
+      # modified clang, but clang_use_allocated_type=1 implies clang=1
+      # TODO(dmikurube): Add a link to a description page.
+      # TODO(dmikurube): Support mac.

[Alexander Potapenko, 2012/08/02 14:57:12]

Note that tcmalloc does not work on Mac within Chromium.

[Dai Mikurube (NOT FULLTIME), 2012/08/02 16:14:35]

Ah, that's true.  Thanks.
I have to find another allocated-type-map storage in Mac...

+      'clang_use_allocated_type%': 0,
+
       # Set to true to instrument the code with function call logger.
       # See src/third_party/cygprofile/cyg-profile.cc for details.
       'order_profiling%': 0,
 
       # Use the provided profiled order file to link Chrome image with it.
       # This makes Chrome faster by better using CPU cache when executing code.
       # This is known as PGO (profile guided optimization).
       # See https://sites.google.com/a/google.com/chrome-msk/dev/boot-speed-up-effort
       'order_text_section%' : "",
 
@@ skipping 923 matching lines @@
         # third_party/asan may be different from the default one.
         # TODO(glider): this isn't true anymore, need to check if we can use the
         # plugins now.
         'clang_use_chrome_plugins%': 0,
       }],
 
       ['tsan==1', {
         'clang%': 1,
       }],
 
+      ['clang_use_allocated_type==1', {
+        'clang%': 1,
+        'clang_use_chrome_plugins%': 0,
+        'make_clang_dir%': 'third_party/llvm-allocated-type/Linux_x64',
+      }],
+
       # On valgrind bots, override the optimizer settings so we don't inline too
       # much and make the stacks harder to figure out.
       #
       # TODO(rnk): Kill off variables that no one else uses and just implement
       # them under a build_for_tool== condition.
       ['build_for_tool=="memcheck" or build_for_tool=="tsan"', {
         # gcc flags
         'mac_debug_optimization': '1',
         'mac_release_optimization': '1',
         'release_optimize': '1',
@@ skipping 385 matching lines @@
         'defines': ['ENABLE_AUTOMATION=1'],
       }],
       ['enable_printing==1', {
         'defines': ['ENABLE_PRINTING=1'],
       }],
       ['enable_captive_portal_detection==1', {
         'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'],
       }],
     ],  # conditions for 'target_defaults'
     'target_conditions': [
+      ['_type=="executable" or _type=="loadable_module"', {
+        'target_conditions': [
+          ['_target_name=="mksnapshot" or _target_name=="protoc" or _target_name=="ppGoogleNaClPluginChrome"', {

[Dai Mikurube (NOT FULLTIME), 2012/08/02 07:43:55]

Some binaries doesn't use tcmalloc.  We use no-op __op_{new|delete|_intercept__
for these binaries since the allocated type mapping is recorded in a
tcmalloc-dependent data structure.

[Alexander Potapenko, 2012/08/02 14:57:12]

Please write a comment about this.

[Dai Mikurube (NOT FULLTIME), 2012/08/02 16:14:35]

Yes, I'll do that.  Thank you.

[Dai Mikurube (NOT FULLTIME), 2012/08/03 10:01:50]

Done.

+            # Ignore allocated types.
+            'conditions': [
+              ['clang==1 and clang_use_allocated_type==1', {
+                'dependencies': [
+                  '<!(realpath <(DEPTH)/base/allocator/allocator.gyp)' + ':allocated_type_ignore#target',
+                ]},
+              ],
+            ]}, {
+            # Store allocated types in TCMalloc's allocated_type_map (extended).
+            'conditions': [
+              ['clang==1 and clang_use_allocated_type==1', {
+                'dependencies': [
+                  '<!(realpath <(DEPTH)/base/allocator/allocator.gyp)' + ':allocated_type_tcmalloc#target',

[Nico, 2012/08/02 15:35:03]

The realpath bit here shouldn't be needed

[Dai Mikurube (NOT FULLTIME), 2012/08/02 16:14:35]

It is actually needed because of http://crrev.com/146172.
(I was surprised when it happened.)

[Nico, 2012/08/02 16:18:49]

No other dependency in gyp uses realpath though, right? Why is this special?

It feels like we should open a bug for this being necessary and probably revert
146172 if this is the consequence :-/

[Dai Mikurube (NOT FULLTIME), 2012/08/02 16:54:39]

I guess it happens because it is a very hacky gyp dependency description.  This
'dependencies' is lazily evaluated after most paths are translated using
'script_dir' and other parameters.

To describe it completely, I have to reread gyp.  I remember that it is an
effect of 'target_conditions'.  Such a hacky dependency is required since we
need to add dependency depending on its target.  (gyp is complicated...)

+                ]},
+              ],
+            ]},
+          ]
+        ]},
+      ],
       ['enable_wexit_time_destructors==1', {
         'conditions': [
           [ 'clang==1', {
             'cflags': [
               '-Wexit-time-destructors',
             ],
             'xcode_settings': {
               'WARNING_CFLAGS': [
                 '-Wexit-time-destructors',
               ],
@@ skipping 723 matching lines @@
             'cflags': [
               '-Xclang', '-add-plugin', '-Xclang', '<(clang_add_plugin)',
             ],
           }],
           ['clang==1 and "<(GENERATOR)"=="ninja"', {
             'cflags': [
               # See http://crbug.com/110262
               '-fcolor-diagnostics',
             ],
           }],
+          ['clang==1 and clang_use_allocated_type==1', {

[Alexander Potapenko, 2012/08/03 09:57:07]

If clang_use_allocated_type=1 implies clang=1, you don't need to check both.

[Dai Mikurube (NOT FULLTIME), 2012/08/07 10:39:18]

Done.

+            'cflags_cc!': ['-fno-rtti'],
+            'cflags_cc+': ['-gline-tables-only'],
+            'target_conditions': [
+                ['_target_name!="allocator" and _target_name!="allocator_extension_thunks" and _target_name!="libcmt" and _target_name!="allocator_extension_thunks_win64" and _target_name!="allocated_type_log" and _target_name!="allocated_type_ignore" and _target_name!="allocated_type_tcmalloc"', {
+                    'cflags_cc+': [
+                        '-frtti',
+                        '-fintercept-allocation-functions',
+                        '-I../../base/allocator',
+                        '-include',
+                        'allocated_type.h',
+                    ],
+                }],
+            ],
+            'defines': ['USE_ALLOCATED_TYPE'],
+          }],
           ['asan==1', {
             'target_conditions': [
               ['_toolset=="target"', {
                 'cflags': [
                   '-faddress-sanitizer',
                   '-fno-omit-frame-pointer',
                 ],
                 'ldflags': [
                   '-faddress-sanitizer',
                 ],
@@ skipping 994 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }