base/allocator/allocated_type.h - Issue 10411047: Type profiler by intercepting 'new' and 'delete' expressions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/allocator/allocated_type.h

Issue 10411047: Type profiler by intercepting 'new' and 'delete' expressions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove some comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_ALLOCATOR_ALLOCATED_TYPE_INTERCEPT_H_
	Alexander Potapenko 2012/08/03 09:57:07 Please either rename the file or the guard definit Please either rename the file or the guard definition. Dai Mikurube (NOT FULLTIME) 2012/08/07 10:39:18 Done. Show quoted text On 2012/08/03 09:57:07, Alexander Potapenko wrote: > Please either rename the file or the guard definition. Done.
	6 #define BASE_ALLOCATOR_ALLOCATED_TYPE_INTERCEPT_H_

	7

	8 #include <cstddef>

	9 #include <typeinfo>

	10

	11 void* __op_new_intercept__(void*, size_t, const std::type_info&);
	jar (doing other things) 2012/08/02 23:38:30 nit: Declarations should have variable names, matc nit: Declarations should have variable names, matching that seen in the definition. Dai Mikurube (NOT FULLTIME) 2012/08/03 10:01:50 Done. Show quoted text On 2012/08/02 23:38:30, jar wrote: > nit: Declarations should have variable names, matching that seen in the > definition. Done.
	12 void* __op_delete_intercept__(void*, size_t, const std::type_info &);
	Dai Mikurube (NOT FULLTIME) 2012/08/02 07:43:55 These functions are inserted around all 'new' and These functions are inserted around all 'new' and 'delete' expressions by the compiler option '-fintercept-allocation-functions' introduced in http://crrev.com/149572. Alexander Potapenko 2012/08/02 14:57:12 If you need to clarify something about the change, If you need to clarify something about the change, please write a comment in the code. Dai Mikurube (NOT FULLTIME) 2012/08/02 16:14:35 Ok, I'll do that. (I added these codereview comme Show quoted text On 2012/08/02 14:57:12, Alexander Potapenko wrote: > If you need to clarify something about the change, please write a comment in the > code. Ok, I'll do that. (I added these codereview comments just before leaving. I didn't have time to re-upload.) Dai Mikurube (NOT FULLTIME) 2012/08/03 10:01:50 Done. Show quoted text On 2012/08/02 16:14:35, Dai Mikurube wrote: > On 2012/08/02 14:57:12, Alexander Potapenko wrote: > > If you need to clarify something about the change, please write a comment in > the > > code. > > Ok, I'll do that. (I added these codereview comments just before leaving. I > didn't have time to re-upload.) Done.
	13

	14 #endif // BASE_ALLOCATOR_ALLOCATED_TYPE_INTERCEPT_H_

OLD	NEW

« no previous file with comments | « no previous file | base/allocator/allocated_type_ignore.cc » ('j') | base/allocator/allocated_type_ignore.cc » ('J')