Type profiler by intercepting 'new' and 'delete' expressions.

base/allocator/allocator.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'jemalloc_dir': '../../third_party/jemalloc/chromium',
     'tcmalloc_dir': '../../third_party/tcmalloc/chromium',
     'use_vtable_verify%': 0,
   },
@@ skipping 285 matching lines @@
       'configurations': {
         'Debug_Base': {
           'msvs_settings': {
             'VCCLCompilerTool': {
               'RuntimeLibrary': '0',
             },
           },
         },
       },
       'conditions': [
+        ['OS=="linux" and clang_type_profiler==1', {
+          'dependencies': [
+            'type_profiler_tcmalloc',
+          ],
+          # It is undoing dependencies and cflags_cc for type_profiler which
+          # build/common.gypi injects into all targets.
+          'dependencies!': [
+            'type_profiler',
+          ],
+          'cflags_cc!': [
+            '-fintercept-allocation-functions',
+          ],
+        }],
         ['OS=="win"', {
           'defines': [
             'PERFTOOLS_DLL_DECL=',
           ],
           'defines!': [
             # tcmalloc source files unconditionally define this, remove it from
             # the list of defines that common.gypi defines globally.
             'NOMINMAX',
           ],
           'dependencies': [
@@ skipping 143 matching lines @@
       'target_name': 'allocator_extension_thunks',
       'type': 'static_library',
       'sources': [
         'allocator_extension_thunks.cc',
         'allocator_extension_thunks.h',
       ],
       'toolsets': ['host', 'target'],
       'include_dirs': [
         '../../'
       ],
+      'conditions': [
+        ['OS=="linux" and clang_type_profiler==1', {
+          # It is undoing dependencies and cflags_cc for type_profiler which
+          # build/common.gypi injects into all targets.
+          'dependencies!': [
+            'type_profiler',
+          ],
+          'cflags_cc!': [
+            '-fintercept-allocation-functions',
+          ],
+        }],
+      ],
     },
    ],
   'conditions': [
     ['OS=="win"', {
       'targets': [
         {
           'target_name': 'libcmt',
           'type': 'none',
           'actions': [
             {
@@ skipping 62 matching lines @@
           '<(tcmalloc_dir)/src',
         ],
         'dependencies': [
           '../../testing/gtest.gyp:gtest',
           '../base.gyp:base',
           'allocator',
         ],
       },
       ],
     }],
+    ['OS=="linux" and clang_type_profiler==1', {
+      # Some targets in this section undo dependencies and cflags_cc for
+      # type_profiler which build/common.gypi injects into all targets.
+      'targets': [
+        {
+          'target_name': 'type_profiler',
+          'type': 'static_library',
+          'dependencies!': [
+            'type_profiler',
+          ],
+          'cflags_cc!': [
+            '-fintercept-allocation-functions',
+          ],
+          'include_dirs': [
+            '../..',
+          ],
+          'sources': [
+            'type_profiler.cc',
+            'type_profiler.h',
+            'type_profiler_control.h',
+          ],
+        },
+        {
+          'target_name': 'type_profiler_tcmalloc',
+          'type': 'static_library',
+          'dependencies!': [
+            'type_profiler',
+          ],
+          'cflags_cc!': [
+            '-fintercept-allocation-functions',
+          ],
+          'include_dirs': [
+            '<(tcmalloc_dir)/src',
+            '../..',

[Ryan Sleevi, 2012/09/13 09:13:25]

Why the ../../ include (which is effectively <(DEPTH)) ?

What's being included here that needs the Chromium scope?

Seems like it can/should be removed

[Dai Mikurube (NOT FULLTIME), 2012/09/13 10:45:04]

Without "../..", I cannot include base/allocator/type_profiler_tcmalloc.h... 
Isn't it???

I used ../.. (instead of DEPTH) for consistency with other targets in this file.


When removed, I was said:

[2/12] CXX obj/base/allocator/type_profiler_tcmalloc.type_profiler_tcmalloc.o
...
../../base/allocator/type_profiler_tcmalloc.cc:7:10: fatal error:
'base/allocator/type_profiler_tcmalloc.h' file not found
#include "base/allocator/type_profiler_tcmalloc.h"
         ^
1 error generated.


[2/12] CXX
obj/third_party/tcmalloc/chromium/src/type_profiler_tcmalloc.type_profiler_map.o
...
In file included from
../../third_party/tcmalloc/chromium/src/type_profiler_map.cc:7:
../../third_party/tcmalloc/chromium/src/config.h:7:10: fatal error:
'build/build_config.h' file not found
#include "build/build_config.h"
         ^
1 error generated.

[Ryan Sleevi, 2012/09/14 23:11:05]

Thank you for your clarification.

It seems that most targets omit this, as they depend directly on base, which has
a block that does
'direct_dependent_settings': {
  'include_dirs': [ '..' ]
}

That ensures the equivalent of this statement.

While it's the dominant pattern to omit it when depending on base/ (such as
'type_profiler_[map_]unittests' do), I think it's better to keep what you have.
Just something to consider in future CLs in other areas.

[Dai Mikurube (NOT FULLTIME), 2012/09/17 03:57:27]

Thanks for the information.  I keep it as is.

+          ],
+          'sources': [
+            'type_profiler_tcmalloc.cc',
+            'type_profiler_tcmalloc.h',
+            '<(tcmalloc_dir)/src/type_profiler_map.cc',
+            '<(tcmalloc_dir)/src/gperftools/type_profiler_map.h',

[Ryan Sleevi, 2012/09/13 09:13:25]

nit: sort

[Dai Mikurube (NOT FULLTIME), 2012/09/13 10:45:04]

Done.

+          ],
+        },
+        {
+          'target_name': 'type_profiler_unittests',
+          'type': 'executable',
+          'dependencies': [
+            '../../testing/gtest.gyp:gtest',
+            '../base.gyp:base',
+            'allocator',
+            'type_profiler_tcmalloc',
+          ],
+          'include_dirs': [
+            '../..',
+          ],
+          'sources': [
+            'type_profiler_control.cc',
+            'type_profiler_control.h',
+            'type_profiler_unittests.cc',
+          ],
+        },
+        {
+          'target_name': 'type_profiler_map_unittests',
+          'type': 'executable',
+          'dependencies': [
+            '../../testing/gtest.gyp:gtest',
+            '../base.gyp:base',
+            'allocator',
+          ],
+          'dependencies!': [
+            'type_profiler',
+          ],
+          'cflags_cc!': [
+            '-fintercept-allocation-functions',
+          ],
+          'include_dirs': [
+            '<(tcmalloc_dir)/src',
+            '../..',
+          ],
+          'sources': [
+            'type_profiler_map_unittests.cc',
+            '<(tcmalloc_dir)/src/type_profiler_map.cc',
+            '<(tcmalloc_dir)/src/gperftools/type_profiler_map.h',

[Ryan Sleevi, 2012/09/13 09:13:25]

nit: sort

[Dai Mikurube (NOT FULLTIME), 2012/09/13 10:45:04]

Done.

+          ],
+        },
+      ],
+    }],
   ],
 }