Browser Plugin: WebContents should notify when it's restored

chrome/browser/ui/gtk/download/download_started_animation_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_started_animation.h"
 
 #include <math.h>
 
 #include <gtk/gtk.h>
 
 #include "base/message_loop.h"
+#include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/theme_resources.h"
 #include "ui/base/animation/linear_animation.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/rect.h"
@@ skipping 77 matching lines @@
   height_ = gdk_pixbuf_get_height(kDownloadImage);
 
   // If we're too small to show the download image, then don't bother -
   // the shelf will be enough.
   web_contents_->GetContainerBounds(&web_contents_bounds_);
   if (web_contents_bounds_.height() < height_)
     return;
 
   registrar_.Add(
       this,
-      content::NOTIFICATION_WEB_CONTENTS_HIDDEN,
+      content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
       content::Source<WebContents>(web_contents_));
   registrar_.Add(
       this,
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::Source<WebContents>(web_contents_));
 
   // TODO(estade): don't show up on the wrong virtual desktop.
 
   popup_ = gtk_window_new(GTK_WINDOW_POPUP);
   GtkWidget* image = gtk_image_new_from_pixbuf(kDownloadImage);
@@ skipping 35 matching lines @@
 }
 
 void DownloadStartedAnimationGtk::Close() {
   if (!web_contents_)
     return;
 
   DCHECK(popup_);
 
   registrar_.Remove(
       this,
-      content::NOTIFICATION_WEB_CONTENTS_HIDDEN,
+      content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
       content::Source<WebContents>(web_contents_));
   registrar_.Remove(
       this,
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::Source<WebContents>(web_contents_));
 
   web_contents_ = NULL;
   gtk_widget_destroy(popup_);
   MessageLoop::current()->DeleteSoon(FROM_HERE, this);
 }
@@ skipping 13 matching lines @@
 
     // This only works when there's a compositing manager running. Oh well.
     gtk_window_set_opacity(GTK_WINDOW(popup_), opacity);
   }
 }
 
 void DownloadStartedAnimationGtk::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
+  if (type == content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED) {
+    bool visible = *content::Details<bool>(details).ptr();
+    if (visible)
+      return;
+  }
   Close();
 }
 
 }  // namespace
 
 // static
 void DownloadStartedAnimation::Show(WebContents* web_contents) {
   // The animation will delete itself.
   new DownloadStartedAnimationGtk(web_contents);
 }