Browser Plugin: WebContents should notify when it's restored

chrome/browser/autofill/autofill_popup_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_popup_view.h"
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_external_delegate.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 31 matching lines @@
 
 AutofillPopupView::AutofillPopupView(
     content::WebContents* web_contents,
     AutofillExternalDelegate* external_delegate)
     : external_delegate_(external_delegate),
       selected_line_(kNoSelection) {
   if (!web_contents)
     return;
 
   registrar_.Add(this,
-                 content::NOTIFICATION_WEB_CONTENTS_HIDDEN,
+                 content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
                  content::Source<content::WebContents>(web_contents));
   registrar_.Add(
       this,
       content::NOTIFICATION_NAV_ENTRY_COMMITTED,
       content::Source<content::NavigationController>(
           &(web_contents->GetController())));
 }
 
 AutofillPopupView::~AutofillPopupView() {}
 
@@ skipping 126 matching lines @@
       (autofill_unique_ids_[0] > 0 ||
        autofill_unique_ids_[0] ==
          WebAutofillClient::MenuItemIDAutocompleteEntry ||
        autofill_unique_ids_[0] == WebAutofillClient::MenuItemIDPasswordEntry ||
        autofill_unique_ids_[0] == WebAutofillClient::MenuItemIDDataListEntry);
 }
 
 void AutofillPopupView::Observe(int type,
                                 const content::NotificationSource& source,
                                 const content::NotificationDetails& details) {
-  if (type == content::NOTIFICATION_WEB_CONTENTS_HIDDEN
-      || type == content::NOTIFICATION_NAV_ENTRY_COMMITTED)
+  bool visible = true;
+  if (type == content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED)
+    visible = *content::Details<bool>(details).ptr();
+  if (!visible || type == content::NOTIFICATION_NAV_ENTRY_COMMITTED)

[jam, 2012/05/18 23:40:51]

nit: this code is not that readable. better to make it

if (type == content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED)) {
  if (!*content::Details<bool>(details).ptr())
    Hide();
} else if (type == content::NOTIFICATION_NAV_ENTRY_COMMITTED)
  Hide();
}

[Fady Samuel, 2012/05/19 15:59:02]

Done.

     Hide();
 }