Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 10409093: [FileBrowser] Fixed tab navigation for detail-thumbnail-settings buttons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index 7788b21821112fb68af1e03572046d8717fa7683..1d8ac66e05e82b977c414844749987a2f6e9e19f 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -655,9 +655,14 @@ FileManager.prototype = {
this.dialogDom_.querySelector('div.sidebar-splitter'));
this.dialogContainer_ = this.dialogDom_.querySelector('.dialog-container');
- this.dialogDom_.querySelector('#detail-view').addEventListener(
+
+ this.detailViewButton_ = this.dialogDom_.querySelector('#detail-view');
+ this.detailViewButton_.addEventListener(
'click', this.onDetailViewButtonClick_.bind(this));
- this.dialogDom_.querySelector('#thumbnail-view').addEventListener(
+
+ this.thumbnailViewButton_ = this.dialogDom_
+ .querySelector('#thumbnail-view');
dgozman 2012/05/23 14:44:41 Binary operators (including dot) should be before
Dmitry Zvorygin 2012/05/23 14:51:58 Done.
+ this.thumbnailViewButton_.addEventListener(
'click', this.onThumbnailViewButtonClick_.bind(this));
this.syncButton = this.dialogDom_.querySelector('#gdata-sync-settings');
@@ -3845,12 +3850,12 @@ FileManager.prototype = {
FileManager.prototype.onDetailViewButtonClick_ = function(event) {
this.setListType(FileManager.ListType.DETAIL);
- this.currentList_.focus();
+ this.thumbnailViewButton_.focus();
dgozman 2012/05/23 14:44:41 Revert this as discussed offline.
Dmitry Zvorygin 2012/05/23 14:51:58 Done.
};
FileManager.prototype.onThumbnailViewButtonClick_ = function(event) {
this.setListType(FileManager.ListType.THUMBNAIL);
- this.currentList_.focus();
+ this.detailViewButton_.focus();
};
/**

Powered by Google App Engine
This is Rietveld 408576698