[FileBrowser] Fixed tab navigation for detail-thumbnail-settings buttons.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * FileManager constructor.
  *
  * FileManager objects encapsulate the functionality of the file selector
  * dialogs, as well as the full screen file manager application (though the
  * latter is not yet implemented).
@@ skipping 637 matching lines @@
 
     this.deleteButton_.addEventListener('click',
         this.onDeleteButtonClick_.bind(this));
     this.deleteButton_.addEventListener('keypress',
         this.onDeleteButtonKeyPress_.bind(this));
 
     this.decorateSplitter(
         this.dialogDom_.querySelector('div.sidebar-splitter'));
 
     this.dialogContainer_ = this.dialogDom_.querySelector('.dialog-container');
-    this.dialogDom_.querySelector('#detail-view').addEventListener(
+
+    this.detailViewButton_ = this.dialogDom_.querySelector('#detail-view');
+    this.detailViewButton_.addEventListener(
         'click', this.onDetailViewButtonClick_.bind(this));
-    this.dialogDom_.querySelector('#thumbnail-view').addEventListener(
+
+    this.thumbnailViewButton_ = this.dialogDom_
+        .querySelector('#thumbnail-view');

[dgozman, 2012/05/23 14:44:41]

Binary operators (including dot) should be before line break.

[Dmitry Zvorygin, 2012/05/23 14:51:58]

Done.

+    this.thumbnailViewButton_.addEventListener(
         'click', this.onThumbnailViewButtonClick_.bind(this));
 
     this.syncButton = this.dialogDom_.querySelector('#gdata-sync-settings');
     this.syncButton.addEventListener('click', this.onGDataPrefClick_.bind(
         this, 'cellularDisabled', false /* not inverted */));
 
     this.hostedButton = this.dialogDom_.querySelector('#gdata-hosted-settings');
     this.hostedButton.addEventListener('click', this.onGDataPrefClick_.bind(
         this, 'hostedFilesDisabled', true /* inverted */));
 
@@ skipping 3167 matching lines @@
     function onError(error) {
       self.alert.show(strf('ERROR_CREATING_FOLDER', current(),
                            getFileErrorString(error.code)));
     }
 
     tryCreate();
   };
 
   FileManager.prototype.onDetailViewButtonClick_ = function(event) {
     this.setListType(FileManager.ListType.DETAIL);
-    this.currentList_.focus();
+    this.thumbnailViewButton_.focus();

[dgozman, 2012/05/23 14:44:41]

Revert this as discussed offline.

[Dmitry Zvorygin, 2012/05/23 14:51:58]

Done.

   };
 
   FileManager.prototype.onThumbnailViewButtonClick_ = function(event) {
     this.setListType(FileManager.ListType.THUMBNAIL);
-    this.currentList_.focus();
+    this.detailViewButton_.focus();
   };
 
   /**
    * KeyDown event handler for the document.
    */
   FileManager.prototype.onKeyDown_ = function(event) {
     if (event.srcElement === this.renameInput_) {
       // Ignore keydown handler in the rename input box.
       return;
     }
@@ skipping 743 matching lines @@
     function closeBanner() {
       self.cleanupGDataWelcome_();
       // Stop showing the welcome banner.
       localStorage[WELCOME_HEADER_COUNTER_KEY] = WELCOME_HEADER_COUNTER_LIMIT;
     }
 
     return maybeShowBanner;
   };
 })();