chrome/renderer/extensions/extension_custom_bindings.cc - Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_custom_bindings.cc

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc ('K') | « chrome/renderer/extensions/event_bindings.cc ('k') | chrome/renderer/extensions/extension_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/extension_custom_bindings.cc

===================================================================

--- chrome/renderer/extensions/extension_custom_bindings.cc (revision 138369)

+++ chrome/renderer/extensions/extension_custom_bindings.cc (working copy)

@@ -7,11 +7,11 @@

#include <string>

#include "base/string_util.h"

-#include "chrome/common/chrome_view_type.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_action.h"

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/common/url_constants.h"

+#include "chrome/common/view_type.h"

#include "chrome/renderer/extensions/extension_dispatcher.h"

#include "chrome/renderer/extensions/extension_helper.h"

#include "content/public/renderer/render_view.h"

@@ -49,9 +49,9 @@

std::string view_type_string = *v8::String::Utf8Value(args[1]->ToString());

StringToUpperASCII(&view_type_string);

- // |view_type| == content::VIEW_TYPE_INVALID means getting any type of

+ // |view_type| == chrome::VIEW_TYPE_INVALID means getting any type of

// views.

- content::ViewType view_type = content::VIEW_TYPE_INVALID;

+ chrome::ViewType view_type = chrome::VIEW_TYPE_INVALID;

if (view_type_string == chrome::kViewTypeBackgroundPage) {

view_type = chrome::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;

} else if (view_type_string == chrome::kViewTypeInfobar) {