chrome/common/view_type.h - Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/view_type.h

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc ('K') | « chrome/common/extensions/extension_messages.h ('k') | chrome/common/view_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/view_type.h

===================================================================

--- chrome/common/view_type.h (revision 138369)

+++ chrome/common/view_type.h (working copy)

@@ -2,12 +2,10 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef CHROME_COMMON_CHROME_VIEW_TYPE_H_

-#define CHROME_COMMON_CHROME_VIEW_TYPE_H_

+#ifndef CHROME_COMMON_VIEW_TYPE_H_

+#define CHROME_COMMON_VIEW_TYPE_H_

#pragma once

-#include "content/public/common/view_type.h"

namespace chrome {

// Icky RTTI used by a few systems to distinguish the host type of a given

@@ -16,8 +14,7 @@

// TODO(aa): Remove this and teach those systems to keep track of their own

// data.

enum ViewType {

- VIEW_TYPE_CHROME_START = content::VIEW_TYPE_CONTENT_END,

+ VIEW_TYPE_INVALID,

VIEW_TYPE_APP_SHELL,

VIEW_TYPE_BACKGROUND_CONTENTS,

VIEW_TYPE_EXTENSION_BACKGROUND_PAGE,

@@ -43,4 +40,4 @@

} // namespace chrome

-#endif // CHROME_COMMON_CHROME_VIEW_TYPE_H_

+#endif // CHROME_COMMON_VIEW_TYPE_H_