chrome/browser/extensions/api/web_navigation/web_navigation_api.cc - Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/extension_event_router.cc » ('j') | chrome/browser/extensions/extension_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

===================================================================

--- chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (revision 138369)

+++ chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (working copy)

@@ -17,8 +17,8 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/tab_contents/retargeting_details.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

+#include "chrome/browser/view_type_utils.h"

#include "chrome/common/chrome_notification_types.h"

-#include "chrome/common/chrome_view_type.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/resource_request_details.h"

#include "content/public/browser/navigation_details.h"

@@ -447,7 +447,7 @@

if (!tab_observer) {

// If you hit this DCHECK(), please add reproduction steps to

// http://crbug.com/109464.

- DCHECK(details->source_web_contents->GetViewType() !=

+ DCHECK(chrome::GetViewType(details->source_web_contents) !=

chrome::VIEW_TYPE_TAB_CONTENTS);

return;

}