Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/renderer/extensions/extension_helper.h

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_helper.h
===================================================================
--- chrome/renderer/extensions/extension_helper.h (revision 138369)
+++ chrome/renderer/extensions/extension_helper.h (working copy)
@@ -11,9 +11,9 @@
#include "base/memory/linked_ptr.h"
#include "base/memory/scoped_ptr.h"
+#include "chrome/common/chrome_view_type.h"
#include "content/public/renderer/render_view_observer.h"
#include "content/public/renderer/render_view_observer_tracker.h"
-#include "content/public/common/view_type.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLResponse.h"
class ExtensionDispatcher;
@@ -42,7 +42,7 @@
static std::vector<content::RenderView*> GetExtensionViews(
const std::string& extension_id,
int browser_window_id,
- content::ViewType view_type);
+ chrome::ViewType view_type);
// Returns the given extension's background page, or NULL if none.
static content::RenderView* GetBackgroundPage(
@@ -60,7 +60,7 @@
string16* error);
int browser_window_id() const { return browser_window_id_; }
- content::ViewType view_type() const { return view_type_; }
+ chrome::ViewType view_type() const { return view_type_; }
private:
// RenderViewObserver implementation.
@@ -91,7 +91,7 @@
void OnExtensionDispatchOnDisconnect(int port_id, bool connection_error);
void OnExecuteCode(const ExtensionMsg_ExecuteCode_Params& params);
void OnGetApplicationInfo(int page_id);
- void OnNotifyRendererViewType(content::ViewType view_type);
+ void OnNotifyRendererViewType(chrome::ViewType view_type);
void OnUpdateBrowserWindowId(int window_id);
// Callback triggered when we finish downloading the application definition
@@ -127,7 +127,7 @@
int pending_app_icon_requests_;
// Type of view attached with RenderView.
- content::ViewType view_type_;
+ chrome::ViewType view_type_;
// Id number of browser window which RenderView is attached to.
int browser_window_id_;

Powered by Google App Engine
This is Rietveld 408576698