chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/automation/automation_util.cc ('K') | « chrome/browser/ui/views/extensions/extension_view.cc ('k') | chrome/common/chrome_view_type.h » ('j') | chrome/common/chrome_view_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

===================================================================

--- chrome/browser/ui/webui/extensions/extension_settings_handler.cc (revision 138369)

+++ chrome/browser/ui/webui/extensions/extension_settings_handler.cc (working copy)

@@ -801,13 +801,14 @@

for (std::set<RenderViewHost*>::const_iterator iter = views.begin();

iter != views.end(); ++iter) {

RenderViewHost* host = *iter;

- int host_type = host->GetDelegate()->GetRenderViewType();

+ WebContents* web_contents = WebContents::FromRenderViewHost(host);

+ chrome::ViewType host_type = chrome::GetViewType(web_contents);

if (host == deleting_rvh_ ||

chrome::VIEW_TYPE_EXTENSION_POPUP == host_type ||

chrome::VIEW_TYPE_EXTENSION_DIALOG == host_type)

continue;

- GURL url = host->GetDelegate()->GetURL();

+ GURL url = web_contents->GetURL();

content::RenderProcessHost* process = host->GetProcess();

result->push_back(

ExtensionPage(url, process->GetID(), host->GetRoutingID(),