chrome/browser/bookmarks/bookmark_manager_extension_api.cc - Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_manager_extension_api.cc

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/automation/automation_util.cc ('K') | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/common/chrome_view_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/bookmark_manager_extension_api.cc

===================================================================

--- chrome/browser/bookmarks/bookmark_manager_extension_api.cc (revision 138369)

+++ chrome/browser/bookmarks/bookmark_manager_extension_api.cc (working copy)

@@ -24,7 +24,6 @@

#include "chrome/common/chrome_view_type.h"

#include "chrome/common/pref_names.h"

#include "content/public/browser/render_view_host.h"

-#include "content/public/browser/render_view_host_delegate.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_ui.h"

#include "grit/generated_resources.h"

@@ -385,8 +384,9 @@

EXTENSION_FUNCTION_VALIDATE(

GetNodesFromArguments(model, args_.get(), 0, &nodes));

- if (render_view_host_->GetDelegate()->GetRenderViewType() ==

- chrome::VIEW_TYPE_TAB_CONTENTS) {

+ WebContents* web_contents =

+ WebContents::FromRenderViewHost(render_view_host_);

+ if (chrome::GetViewType(web_contents) == chrome::VIEW_TYPE_TAB_CONTENTS) {

WebContents* web_contents =

dispatcher()->delegate()->GetAssociatedWebContents();

CHECK(web_contents);

@@ -427,8 +427,9 @@

else

drop_index = drop_parent->child_count();