Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum…

chrome/common/chrome_view_type.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_CHROME_VIEW_TYPE_H_
 #define CHROME_COMMON_CHROME_VIEW_TYPE_H_
 #pragma once
 
-#include "content/public/common/view_type.h"
+namespace content {
+class WebContents;
+}
 
 namespace chrome {
 
 // Icky RTTI used by a few systems to distinguish the host type of a given
 // RenderViewHost or WebContents.
 //
 // TODO(aa): Remove this and teach those systems to keep track of their own
 // data.
 enum ViewType {
-  VIEW_TYPE_CHROME_START = content::VIEW_TYPE_CONTENT_END,
-
+  VIEW_TYPE_INVALID,
   VIEW_TYPE_APP_SHELL,
   VIEW_TYPE_BACKGROUND_CONTENTS,
   VIEW_TYPE_EXTENSION_BACKGROUND_PAGE,
   VIEW_TYPE_EXTENSION_DIALOG,
   VIEW_TYPE_EXTENSION_INFOBAR,
   VIEW_TYPE_EXTENSION_POPUP,
   VIEW_TYPE_NOTIFICATION,
   VIEW_TYPE_PANEL,
   VIEW_TYPE_TAB_CONTENTS,
 };
 
+// Get/Set the type of a WebContents.
+// GetViewType handles a NULL |tab| for convenience.

[Avi (use Gerrit), 2012/05/23 03:22:52]

... and returns what if given NULL?

[jam, 2012/05/23 04:18:38]

Done.

+ViewType GetViewType(content::WebContents* tab);
+void SetViewType(content::WebContents* tab, ViewType type);
+
 // Constant strings corresponding to the Type enumeration values.  Used
 // when converting JS arguments.
 extern const char kViewTypeAll[];
 extern const char kViewTypeAppShell[];
 extern const char kViewTypeBackgroundPage[];
 extern const char kViewTypeExtensionDialog[];
 extern const char kViewTypeInfobar[];
 extern const char kViewTypeNotification[];
 extern const char kViewTypePanel[];
 extern const char kViewTypePopup[];
 extern const char kViewTypeTabContents[];
 
 }  // namespace chrome
 
 #endif  // CHROME_COMMON_CHROME_VIEW_TYPE_H_