Fixing activation problem: Pages which refresh themselves should not get focus

chrome/browser/ui/browser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // OS_WIN
@@ skipping 2679 matching lines @@
     GetStatusBubble()->Hide();
 
   // Update the location bar. This is synchronous. We specifically don't
   // update the load state since the load hasn't started yet and updating it
   // will put it out of sync with the actual state like whether we're
   // displaying a favicon, which controls the throbber. If we updated it here,
   // the throbber will show the default favicon for a split second when
   // navigating away from the new tab page.
   ScheduleUIUpdate(contents->web_contents(), content::INVALIDATE_TYPE_URL);
 
+  // In case of multiple windows we do not want to switch windows when this is

[sky, 2012/05/21 17:29:15]

This comment is confusing.

+  // not user initiated (e.g. automatic page refresh) and the current window
+  // is not the window we are targeting.
+  if (!user_initiated &&

[sky, 2012/05/21 17:29:15]

I think you missed a comment from last round: "Combine this with the Focus()
request since that's what it is intended for." Basicaly, I'm saying combine this
with the if on 2708:

if (user_initiated && contents_is_selected && window()->IsActive()

[Mr4D (OOO till 08-26), 2012/05/21 18:18:37]

Ahh. In that case I have misunderstood. Done.

+      (GetSelectedWebContents() != contents->web_contents() ||
+       !window()->IsActive()))
+    return;
+
   if (contents_is_selected)
     contents->web_contents()->Focus();
 }
 
 void Browser::ShowCollectedCookiesDialog(TabContentsWrapper* wrapper) {
   browser::ShowCollectedCookiesDialog(window()->GetNativeHandle(), wrapper);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, PageNavigator implementation:
@@ skipping 692 matching lines @@
 // Browser, content::WebContentsDelegate implementation:
 
 WebContents* Browser::OpenURLFromTab(WebContents* source,
                                      const OpenURLParams& params) {
   browser::NavigateParams nav_params(this, params.url, params.transition);
   nav_params.source_contents = GetTabContentsWrapperAt(
       tab_strip_model_->GetWrapperIndex(source));
   nav_params.referrer = params.referrer;
   nav_params.disposition = params.disposition;
   nav_params.tabstrip_add_types = TabStripModel::ADD_NONE;
-  nav_params.window_action = browser::NavigateParams::SHOW_WINDOW;
+
+  // If the current tab is initiating this, we don't want to update.

[sky, 2012/05/21 17:29:15]

You comment doesn't match what you're doing.

[Mr4D (OOO till 08-26), 2012/05/21 18:18:37]

Done.

+  if (nav_params.window_action != browser::NavigateParams::NO_ACTION ||

[sky, 2012/05/21 17:29:15]

I don't understand this first check. The default is NO_ACTION, so this should
never be true.

[Mr4D (OOO till 08-26), 2012/05/21 18:18:37]

Done. Yes, that is correct (forgotten to remove that).

+      params.disposition != CURRENT_TAB ||

[sky, 2012/05/21 17:29:15]

Why are you checking this?

[Mr4D (OOO till 08-26), 2012/05/21 18:18:37]

Because when a new thing (Popup / Window / Tab) gets opened we want to show it -
even if the (what ever) was not yet active. In case of an automated update a
"CURRENT_TAB" gets passed down which matches our requirement. I added a comment.
But please let me know if you feel that that might be too limiting.

[sky, 2012/05/21 20:42:52]

I believe Navigate takes care of that for you. See the comment and
implementation where it sets the window_action to SHOW.

[Mr4D (OOO till 08-26), 2012/05/21 21:27:12]

Okay, I removed the special check for the current_tab since the latter function
will set the window_action as described.

+      (GetSelectedWebContents() == source && window()->IsActive()))
+    nav_params.window_action = browser::NavigateParams::SHOW_WINDOW;
+
   nav_params.user_gesture = true;
   nav_params.override_encoding = params.override_encoding;
   nav_params.is_renderer_initiated = params.is_renderer_initiated;
   nav_params.transferred_global_request_id =
       params.transferred_global_request_id;
   browser::Navigate(&nav_params);
 
   return nav_params.target_contents ?
       nav_params.target_contents->web_contents() : NULL;
 }
@@ skipping 2002 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         content::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }