Fixing activation problem: Pages which refresh themselves should not get focus

chrome/browser/ui/browser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // OS_WIN
@@ skipping 2677 matching lines @@
     GetStatusBubble()->Hide();
 
   // Update the location bar. This is synchronous. We specifically don't
   // update the load state since the load hasn't started yet and updating it
   // will put it out of sync with the actual state like whether we're
   // displaying a favicon, which controls the throbber. If we updated it here,
   // the throbber will show the default favicon for a split second when
   // navigating away from the new tab page.
   ScheduleUIUpdate(contents->web_contents(), content::INVALIDATE_TYPE_URL);
 
+#if defined(USE_ASH)
+  // When using ash it is not desirable to switch to a new window when the

[sky, 2012/05/18 19:43:30]

Why is this specific to ash? Additionally I'm not sure if this would cause
wierdness if the request is not user_initiated but the window has focus.

[Mr4D (OOO till 08-26), 2012/05/18 20:27:01]

user_initiated:

the problem is that if the page refreshes itself it is not user activated. So we
do not want that the focus gets set to the "dynamic page".

ASH:

Please correct me if I am wrong, but with Chrome itself we do not have the
problem of multiple windows like there.

+  // page refresh wasn't initiated by the user (but instead by a page refresh).
+  if (!user_initiated)
+    return;
+#endif
+
   if (contents_is_selected)
     contents->web_contents()->Focus();
 }
 
 void Browser::ShowCollectedCookiesDialog(TabContentsWrapper* wrapper) {
   browser::ShowCollectedCookiesDialog(window()->GetNativeHandle(), wrapper);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, PageNavigator implementation:
@@ skipping 694 matching lines @@
 // Browser, content::WebContentsDelegate implementation:
 
 WebContents* Browser::OpenURLFromTab(WebContents* source,
                                      const OpenURLParams& params) {
   browser::NavigateParams nav_params(this, params.url, params.transition);
   nav_params.source_contents = GetTabContentsWrapperAt(
       tab_strip_model_->GetWrapperIndex(source));
   nav_params.referrer = params.referrer;
   nav_params.disposition = params.disposition;
   nav_params.tabstrip_add_types = TabStripModel::ADD_NONE;
-  nav_params.window_action = browser::NavigateParams::SHOW_WINDOW;
+#if defined(USE_ASH)

[sky, 2012/05/18 19:43:30]

Whats the motivation for this?

[Mr4D (OOO till 08-26), 2012/05/18 20:27:01]

When this flag gets set, the LoadURL call further down will - many calls later -
also trigger a SetFocus to the window. The idea here is that we only set the
focus to the page if we are not on the current tab. I followed the whole call
chain down, but this seemed to be the best location for a decision since further
down the call chain the knowledge about who was trying to show the page is gone.

If you have a better way of doing this - please let me know!

+  // If the current tab is initiating this, we don't want to update.
+  if (nav_params.window_action != browser::NavigateParams::NO_ACTION ||
+      params.disposition != CURRENT_TAB)
+#endif
+    nav_params.window_action = browser::NavigateParams::SHOW_WINDOW;
   nav_params.user_gesture = true;
   nav_params.override_encoding = params.override_encoding;
   nav_params.is_renderer_initiated = params.is_renderer_initiated;
   nav_params.transferred_global_request_id =
       params.transferred_global_request_id;
   browser::Navigate(&nav_params);
 
   return nav_params.target_contents ?
       nav_params.target_contents->web_contents() : NULL;
 }
@@ skipping 2001 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         content::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }