Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5174)

Unified Diff: chrome/test/ui/ppapi_uitest.cc

Issue 10409032: Enable PPAPINaCl GLIBC browser_tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More ARM build fixes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui/ppapi_uitest.h ('k') | native_client_sdk/src/tools/create_nmf.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ppapi_uitest.cc
diff --git a/chrome/test/ui/ppapi_uitest.cc b/chrome/test/ui/ppapi_uitest.cc
index bec766d33293086902cd3e2b86fd8f45e5fb3245..b00e2a72976b7e72934d47dd4db824b570c1b124 100644
--- a/chrome/test/ui/ppapi_uitest.cc
+++ b/chrome/test/ui/ppapi_uitest.cc
@@ -332,9 +332,6 @@ void OutOfProcessPPAPITest::SetUpCommandLine(CommandLine* command_line) {
command_line->AppendSwitch(switches::kPpapiOutOfProcess);
}
-PPAPINaClTest::PPAPINaClTest() {
-}
-
void PPAPINaClTest::SetUpCommandLine(CommandLine* command_line) {
PPAPITestBase::SetUpCommandLine(command_line);
@@ -348,13 +345,17 @@ void PPAPINaClTest::SetUpCommandLine(CommandLine* command_line) {
}
// Append the correct mode and testcase string
-std::string PPAPINaClTest::BuildQuery(const std::string& base,
+std::string PPAPINaClNewlibTest::BuildQuery(const std::string& base,
const std::string& test_case) {
- return StringPrintf("%smode=nacl&testcase=%s", base.c_str(),
+ return StringPrintf("%smode=nacl_newlib&testcase=%s", base.c_str(),
test_case.c_str());
}
-PPAPINaClTestDisallowedSockets::PPAPINaClTestDisallowedSockets() {
+// Append the correct mode and testcase string
+std::string PPAPINaClGLibcTest::BuildQuery(const std::string& base,
+ const std::string& test_case) {
+ return StringPrintf("%smode=nacl_glibc&testcase=%s", base.c_str(),
+ test_case.c_str());
}
void PPAPINaClTestDisallowedSockets::SetUpCommandLine(
@@ -373,7 +374,7 @@ void PPAPINaClTestDisallowedSockets::SetUpCommandLine(
std::string PPAPINaClTestDisallowedSockets::BuildQuery(
const std::string& base,
const std::string& test_case) {
- return StringPrintf("%smode=nacl&testcase=%s", base.c_str(),
+ return StringPrintf("%smode=nacl_newlib&testcase=%s", base.c_str(),
test_case.c_str());
}
@@ -441,7 +442,10 @@ std::string PPAPINaClTestDisallowedSockets::BuildQuery(
// NaCl based PPAPI tests
#define TEST_PPAPI_NACL_VIA_HTTP(test_name) \
- IN_PROC_BROWSER_TEST_F(PPAPINaClTest, test_name) { \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, test_name) { \
+ RunTestViaHTTP(STRIP_PREFIXES(test_name)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, test_name) { \
RunTestViaHTTP(STRIP_PREFIXES(test_name)); \
}
@@ -453,19 +457,28 @@ std::string PPAPINaClTestDisallowedSockets::BuildQuery(
// NaCl based PPAPI tests with SSL server
#define TEST_PPAPI_NACL_WITH_SSL_SERVER(test_name) \
- IN_PROC_BROWSER_TEST_F(PPAPINaClTest, test_name) { \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, test_name) { \
+ RunTestWithSSLServer(STRIP_PREFIXES(test_name)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, test_name) { \
RunTestWithSSLServer(STRIP_PREFIXES(test_name)); \
}
// NaCl based PPAPI tests with WebSocket server
#define TEST_PPAPI_NACL_VIA_HTTP_WITH_WS(test_name) \
- IN_PROC_BROWSER_TEST_F(PPAPINaClTest, test_name) { \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, test_name) { \
+ RunTestWithWebSocketServer(STRIP_PREFIXES(test_name)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, test_name) { \
RunTestWithWebSocketServer(STRIP_PREFIXES(test_name)); \
}
// NaCl based PPAPI tests requiring an Audio device.
#define TEST_PPAPI_NACL_VIA_HTTP_WITH_AUDIO_OUTPUT(test_name) \
- IN_PROC_BROWSER_TEST_F(PPAPINaClTest, test_name) { \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, test_name) { \
+ RunTestViaHTTPIfAudioOutputAvailable(STRIP_PREFIXES(test_name)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, test_name) { \
RunTestViaHTTPIfAudioOutputAvailable(STRIP_PREFIXES(test_name)); \
}
#endif
« no previous file with comments | « chrome/test/ui/ppapi_uitest.h ('k') | native_client_sdk/src/tools/create_nmf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698