Remove extension application launch code from Browser

chrome/browser/ui/browser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_H_
 #define CHROME_BROWSER_UI_BROWSER_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 91 matching lines @@
   // updated.
   enum Type {
     // If you add a new type, consider updating the test
     // BrowserTest.StartMaximized.
     TYPE_TABBED = 1,
     TYPE_POPUP = 2,
     TYPE_PANEL = 3
   };
 
   // Distinguishes between browsers that host an app (opened from
-  // Browser::OpenApplication), and child browsers created by an app from
-  // Browser::CreateForApp (e.g. by windows.open or the extension API).
+  // ApplicationLauncher::OpenApplication), and child browsers created by an app
+  // from Browser::CreateForApp (e.g. by windows.open or the extension API).
   // TODO(stevenjb): This is currently only needed by the ash Launcher for
   // identifying child panels. Remove this once panels are no longer
   // implemented as Browsers, crbug.com/112198.
   enum AppType {
     APP_TYPE_HOST = 1,
     APP_TYPE_CHILD = 2
   };
 
   // Possible elements of the Browser window.
   enum WindowFeature {
@@ skipping 15 matching lines @@
 
     // The browser is shutting down and there are active downloads
     // that would be cancelled.
     DOWNLOAD_CLOSE_BROWSER_SHUTDOWN,
 
     // There are active downloads associated with this incognito profile
     // that would be canceled.
     DOWNLOAD_CLOSE_LAST_WINDOW_IN_INCOGNITO_PROFILE,
   };
 
+  // Different types of action when web app info is available.
+  // OnDidGetApplicationInfo uses this to dispatch calls.
+  enum WebAppAction {
+    NONE,             // No action at all.
+    CREATE_SHORTCUT,  // Bring up create application shortcut dialog.
+    UPDATE_SHORTCUT   // Update icon for app shortcut.
+  };
+
   struct CreateParams {
     CreateParams();
     CreateParams(Type type, Profile* profile);
 
     static CreateParams CreateForApp(Type type,
                                      const std::string& app_name,
                                      const gfx::Rect& window_bounds,
                                      Profile* profile);
 
     static CreateParams CreateForDevTools(Profile* profile);
@@ skipping 119 matching lines @@
   static Browser* OpenEmptyWindow(Profile* profile);
 
   // Opens a new window with the tabs from |profile|'s TabRestoreService.
   static void OpenWindowWithRestoredTabs(Profile* profile);
 
   // Opens the specified URL in a new browser window in an incognito session.
   // If there is already an existing active incognito session for the specified
   // |profile|, that session is re-used.
   static void OpenURLOffTheRecord(Profile* profile, const GURL& url);
 
-  // Open |extension| in |container|, using |disposition| if container type is
-  // TAB. Returns the WebContents* that was created or NULL. If non-empty,
-  // |override_url| is used in place of the app launch url.
-  static content::WebContents* OpenApplication(
-      Profile* profile,
-      const Extension* extension,
-      extension_misc::LaunchContainer container,
-      const GURL& override_url,
-      WindowOpenDisposition disposition);
-
-#if defined(USE_ASH)
-  // Opens |url| in a new application panel window for the specified url.
-  static content::WebContents* OpenApplicationPanel(
-      Profile* profile,
-      const Extension* extension,
-      const GURL& url);
-#endif
-
-  // Opens a new application window for the specified url. If |as_panel|
-  // is true, the application will be opened as a Browser::Type::APP_PANEL in
-  // app panel window, otherwise it will be opened as as either
-  // Browser::Type::APP a.k.a. "thin frame" (if |extension| is NULL) or
-  // Browser::Type::EXTENSION_APP (if |extension| is non-NULL).
-  // If |app_browser| is not NULL, it is set to the browser that hosts the
-  // returned tab.
-  static content::WebContents* OpenApplicationWindow(
-      Profile* profile,
-      const Extension* extension,
-      extension_misc::LaunchContainer container,
-      const GURL& url,
-      Browser** app_browser);
-
-  // Open |url| in an app shortcut window.  If |update_shortcut| is true,
-  // update the name, description, and favicon of the shortcut.
-  // There are two kinds of app shortcuts: Shortcuts to a URL,
-  // and shortcuts that open an installed application.  This function
-  // is used to open the former.  To open the latter, use
-  // Browser::OpenApplicationWindow().
-  static content::WebContents* OpenAppShortcutWindow(Profile* profile,
-                                                     const GURL& url,
-                                                     bool update_shortcut);
-
-  // Open an application for |extension| using |disposition|.  Returns NULL if
-  // there are no appropriate existing browser windows for |profile|. If
-  // non-empty, |override_url| is used in place of the app launch url.
-  static content::WebContents* OpenApplicationTab(
-      Profile* profile,
-      const Extension* extension,
-      const GURL& override_url,
-      WindowOpenDisposition disposition);
-
   // Opens a new window and opens the bookmark manager.
   static void OpenBookmarkManagerWindow(Profile* profile);
 
 #if defined(OS_MACOSX)
   // Open a new window with history/downloads/help/options (needed on Mac when
   // there are no windows).
   static void OpenAboutWindow(Profile* profile);
   static void OpenHistoryWindow(Profile* profile);
   static void OpenDownloadsWindow(Profile* profile);
   static void OpenHelpWindow(Profile* profile);
@@ skipping 504 matching lines @@
 
   // True when the mouse cursor is locked.
   bool IsMouseLocked() const;
 
   // Called each time the browser window is shown.
   void OnWindowDidShow();
 
   // Show the first run search engine bubble on the location bar.
   void ShowFirstRunBubble();
 
+  void set_pending_web_app_action(WebAppAction action) {
+    pending_web_app_action_ = action;

[sky, 2012/05/18 16:04:02]

It would be great if we could remove this too.

[benwells, 2012/05/21 03:25:54]

I couldn't see a way to get rid of this, but I don't know much about it.

+  }
+
   ExtensionWindowController* extension_window_controller() const {
     return extension_window_controller_.get();
   }
 
  protected:
   // Wrapper for the factory method in BrowserWindow. This allows subclasses to
   // set their own window.
   virtual BrowserWindow* CreateBrowserWindow();
 
  private:
@@ skipping 537 matching lines @@
 
   // Indicates if command execution is blocked.
   bool block_command_execution_;
 
   // Stores the last blocked command id when |block_command_execution_| is true.
   int last_blocked_command_id_;
 
   // Stores the disposition type of the last blocked command.
   WindowOpenDisposition last_blocked_command_disposition_;
 
-  // Different types of action when web app info is available.
-  // OnDidGetApplicationInfo uses this to dispatch calls.
-  enum WebAppAction {
-    NONE,             // No action at all.
-    CREATE_SHORTCUT,  // Bring up create application shortcut dialog.
-    UPDATE_SHORTCUT   // Update icon for app shortcut.
-  };
-
   // Which deferred action to perform when OnDidGetApplicationInfo is notified
   // from a WebContents. Currently, only one pending action is allowed.
   WebAppAction pending_web_app_action_;
 
   // The profile's tab restore service. The service is owned by the profile,
   // and we install ourselves as an observer.
   TabRestoreService* tab_restore_service_;
 
   // Helper which implements the ContentSettingBubbleModel interface.
   scoped_ptr<BrowserContentSettingBubbleModelDelegate>
@@ skipping 21 matching lines @@
   bool window_has_shown_;
 
   // Currently open color chooser. Non-NULL after OpenColorChooser is called and
   // before DidEndColorChooser is called.
   scoped_ptr<content::ColorChooser> color_chooser_;
 
   DISALLOW_COPY_AND_ASSIGN(Browser);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_H_