Handle disconnection events properly for unauthenicated clients.

remoting/host/client_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_CLIENT_SESSION_H_
 #define REMOTING_HOST_CLIENT_SESSION_H_
 
 #include <list>
 
 #include "base/time.h"
@@ skipping 91 matching lines @@
   // be called multiple times. The object should not be used after
   // this method returns.
   void Disconnect();
 
   protocol::ConnectionToClient* connection() const {
     return connection_.get();
   }
 
   const std::string& client_jid() { return client_jid_; }
 
+  bool is_authenticated() { return is_authenticated_;  }

[Wez, 2012/05/18 20:20:57]

You can check |auth_input_filter_.get_stub()| here and avoid having a separate
|is_authenticated_| flag.

[Sergey Ulanov, 2012/05/21 18:20:13]

OnConnectionClosed() resets auth_input_filter_ and we need this method to return
correct value when OnSessionClosed() is called.

[Wez, 2012/05/21 20:33:50]

Hmmm, yes; the teardown logic in ChromotingHost really belongs in ClientSession
- ClientSession should just tell the host when it needs the ScreenRecorder, and
when it's done with it.

[Sergey Ulanov, 2012/05/21 22:27:55]

Added TODO.

+
   // Indicate that local mouse activity has been detected. This causes remote
   // inputs to be ignored for a short time so that the local user will always
   // have the upper hand in 'pointer wars'.
   void LocalMouseMoved(const SkIPoint& new_pos);
 
   // Disable handling of input events from this client. If the client has any
   // keys or mouse buttons pressed then these will be released.
   void SetDisableInputs(bool disable_inputs);
 
  private:
   EventHandler* event_handler_;
 
   // The connection to the client.
   scoped_ptr<protocol::ConnectionToClient> connection_;
 
   std::string client_jid_;
+  bool is_authenticated_;
 
   // The host event stub to which this object delegates. This is the final
   // element in the input pipeline, whose components appear in order below.
   protocol::HostEventStub* host_event_stub_;
 
   // Tracker used to release pressed keys and buttons when disconnecting.
   protocol::InputEventTracker input_tracker_;
 
   // Filter used to disable remote inputs during local input activity.
   RemoteInputFilter remote_input_filter_;
@@ skipping 12 matching lines @@
   // TODO(lambroslambrou): Move floor-control logic, and clamping to screen
   // area, out of this class (crbug.com/96508).
   Capturer* capturer_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientSession);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_CLIENT_SESSION_H_