Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: remoting/host/server_log_entry.cc

Issue 10409017: [Chromoting] Add platform data to heartbeats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improve names and comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/server_log_entry.cc
diff --git a/remoting/host/server_log_entry.cc b/remoting/host/server_log_entry.cc
index 75e2595087d1caf924634a860af9e3e192822aa8..2cf023932aa4385f8411c50853a5b7d1da3aeadb 100644
--- a/remoting/host/server_log_entry.cc
+++ b/remoting/host/server_log_entry.cc
@@ -17,10 +17,13 @@ using remoting::protocol::Session;
namespace remoting {
namespace {
+const char kLogCommand[] = "log";
+
const char kLogEntry[] = "entry";
const char kKeyEventName[] = "event-name";
const char kValueEventNameSessionState[] = "session-state";
+const char kValueEventNameHeartbeat[] = "heartbeat";
const char kKeyRole[] = "role";
const char kValueRoleHost[] = "host";
@@ -53,6 +56,11 @@ ServerLogEntry::ServerLogEntry() {
ServerLogEntry::~ServerLogEntry() {
}
+scoped_ptr<buzz::XmlElement> ServerLogEntry::MakeStanza() {
+ return scoped_ptr<buzz::XmlElement>(
+ new XmlElement(QName(kChromotingXmlNamespace, kLogCommand)));
+}
+
ServerLogEntry* ServerLogEntry::MakeSessionStateChange(bool connected) {
ServerLogEntry* entry = new ServerLogEntry();
entry->Set(kKeyRole, kValueRoleHost);
@@ -61,6 +69,13 @@ ServerLogEntry* ServerLogEntry::MakeSessionStateChange(bool connected) {
return entry;
}
+ServerLogEntry* ServerLogEntry::MakeForHeartbeat() {
Sergey Ulanov 2012/05/21 20:06:02 nit: add "// static" above this line.
simonmorris 2012/05/21 20:40:23 Done.
+ ServerLogEntry* entry = new ServerLogEntry();
+ entry->Set(kKeyRole, kValueRoleHost);
+ entry->Set(kKeyEventName, kValueEventNameHeartbeat);
+ return entry;
+}
+
void ServerLogEntry::AddHostFields() {
#if defined(OS_WIN)
Set(kKeyOsName, kValueOsNameWindows);

Powered by Google App Engine
This is Rietveld 408576698