Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: webkit/support/webkit_support.cc

Issue 10408091: Chromium support of running DumpRenderTree as an apk on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes according to comments in Patch Set 3 Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/support/webkit_support.cc
diff --git a/webkit/support/webkit_support.cc b/webkit/support/webkit_support.cc
index 738b748b6936de3556ba81611429a55e7dd988aa..b719ae3dd81bfe6aa0566f6844c44a58e4ed34ef 100644
--- a/webkit/support/webkit_support.cc
+++ b/webkit/support/webkit_support.cc
@@ -71,6 +71,10 @@
#include "webkit/tools/test_shell/simple_file_system.h"
#include "webkit/tools/test_shell/simple_resource_loader_bridge.h"
+#if defined(OS_ANDROID)
+#include "base/test/test_support_android.h"
+#endif
+
using WebKit::WebCString;
using WebKit::WebDevToolsAgentClient;
using WebKit::WebFileSystem;
@@ -104,6 +108,10 @@ void InitLogging() {
}
#endif
+#if defined(OS_ANDROID)
+ // On Android we expect the log to appear in logcat.
+ InitAndroidTestLogging();
+#else
FilePath log_filename;
PathService::Get(base::DIR_EXE, &log_filename);
log_filename = log_filename.AppendASCII("DumpRenderTree.log");
@@ -123,6 +131,7 @@ void InitLogging() {
const bool kTimestamp = true;
const bool kTickcount = true;
logging::SetLogItems(kProcessId, kThreadId, !kTimestamp, kTickcount);
+#endif // else defined(OS_ANDROID)
}
class TestEnvironment {
@@ -262,7 +271,7 @@ static void SetUpTestEnvironmentImpl(bool unit_test_mode) {
// TestEnvironment, so we create a AtExitManager early and pass its ownership
// to TestEnvironment.
if (!unit_test_mode)
- at_exit_manager = new base::AtExitManager;
+ at_exit_manager = new base::ShadowingAtExitManager;
Paweł Hajdan Jr. 2012/05/25 19:06:08 Don't do that, it's most likely papering over some
Xianzhu 2012/05/29 17:15:55 Now use #if !defined(OS_ANDROID).
BeforeInitialize(unit_test_mode);
test_environment = new TestEnvironment(unit_test_mode, at_exit_manager);
AfterInitialize(unit_test_mode);
« webkit/support/platform_support_android.cc ('K') | « webkit/support/platform_support_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698