Chromium support of running DumpRenderTree as an apk on Android

base/test/test_suite.cc

Index: base/test/test_suite.cc
diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc
index 75e9ff535ff2c500301b43e5a9641748152edbc1..8a5801f0ef793f0cd617a131c4bac1c7d7f9969a 100644
--- a/base/test/test_suite.cc
+++ b/base/test/test_suite.cc
@@ -28,7 +28,7 @@
 #endif
 
 #if defined(OS_ANDROID)
-#include "base/test/test_stub_android.h"
+#include "base/test/test_support_android.h"
 #endif
 
 #if defined(TOOLKIT_GTK)
@@ -102,7 +102,7 @@ void TestSuite::PreInitialize(int argc, char** argv,
   gtk_init_check(&argc, &argv);
 #endif  // defined(TOOLKIT_GTK)
   if (create_at_exit_manager)
-    at_exit_manager_.reset(new base::AtExitManager);
+    at_exit_manager_.reset(new base::ShadowingAtExitManager);

[Paweł Hajdan Jr., 2012/05/25 19:06:08]

This looks Very Bad to me. You should not need that. Why are you using it here?

[Xianzhu, 2012/05/29 17:15:55]

Now use #if !defined(ANDROID_APK_TEST_TARGET). Will change to #if
!defined(OS_ANDROID) after we convert all unit tests to apks.

 
   // Don't add additional code to this function.  Instead add it to
   // Initialize().  See bug 6436.
@@ -237,9 +237,8 @@ void TestSuite::Initialize() {
 #endif
 
 #if defined(OS_ANDROID)
-  InitAndroidTestStub();
-#endif
-
+  InitAndroidTest();
+#else
   // Initialize logging.
   FilePath exe;
   PathService::Get(base::FILE_EXE, &exe);
@@ -253,6 +252,7 @@ void TestSuite::Initialize() {
   // We want process and thread IDs because we may have multiple processes.
   // Note: temporarily enabled timestamps in an effort to catch bug 6361.
   logging::SetLogItems(true, true, true, true);
+#endif  // else defined(OS_ANDROID)
 
   CHECK(base::EnableInProcessStackDumping());
 #if defined(OS_WIN)
@@ -269,11 +269,7 @@ void TestSuite::Initialize() {
     logging::SetLogAssertHandler(UnitTestAssertHandler);
   }
 
-#if !defined(OS_ANDROID)
-  // TODO(michaelbai): The icu can not be compiled in Android now, this should
-  // be enabled once icu is ready. http://b/5406077.
   icu_util::Initialize();
-#endif
 
   CatchMaybeTests();
   ResetCommandLine();