base/test/test_support_android.h - Issue 10408091: Chromium support of running DumpRenderTree as an apk on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/test/test_support_android.h

Issue 10408091: Chromium support of running DumpRenderTree as an apk on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changes according to comments in Patch Set 3 Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_TEST_TEST_SUPPORT_ANDROID_H_

	6 #define BASE_TEST_TEST_SUPPORT_ANDROID_H_

	7

	8 void InitAndroidTestLogging();
	Paweł Hajdan Jr. 2012/05/25 19:06:08 Those should have short comments above each. Those should have short comments above each. Xianzhu 2012/05/29 17:15:55 Done. Show quoted text On 2012/05/25 19:06:08, Paweł Hajdan Jr. wrote: > Those should have short comments above each. Done.
	9 void InitAndroidTestPaths();

	10 void InitAndroidTestMessageLoop();

	11 // Do all of the above.
	Paweł Hajdan Jr. 2012/05/25 19:06:08 Do you need to expose the sub-parts then? Do you need to expose the sub-parts then? Xianzhu 2012/05/29 17:15:55 Yes. For chromium unit tests, InitAndroidTest() is Show quoted text On 2012/05/25 19:06:08, Paweł Hajdan Jr. wrote: > Do you need to expose the sub-parts then? Yes. For chromium unit tests, InitAndroidTest() is enough. For webkit unit tests and layout tests, because in webkit_support.cc the sub-parts are initialized separately, requiring us to provide the init functions of the sub-parts.
	12 void InitAndroidTest();

	13

	14 #endif // BASE_TEST_TEST_SUPPORT_ANDROID_H_

OLD	NEW