chrome/browser/net/chrome_network_delegate.cc - Issue 10407124: Don't force non-session only cookies to be session only cookies, instead delete on shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 10407124: Don't force non-session only cookies to be session only cookies, instead delete on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix tests Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/host_content_settings_map.cc ('k') | chrome/browser/net/clear_on_exit_policy.h » ('j') | chrome/browser/net/sqlite_persistent_cookie_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_network_delegate.cc

diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc

index 2c65be638488e795da5754ef3d53f77efb63b0a6..9abf6c4261555b914b4743dac26039c6ecddf6f3 100644

--- a/chrome/browser/net/chrome_network_delegate.cc

+++ b/chrome/browser/net/chrome_network_delegate.cc

@@ -303,9 +303,6 @@ bool ChromeNetworkDelegate::OnCanSetCookie(const net::URLRequest& request,

bool allow = cookie_settings_->IsSettingCookieAllowed(

request.url(), request.first_party_for_cookies());

- if (cookie_settings_->IsCookieSessionOnly(request.url()))

- options->set_force_session();

erikwright (departed) 2012/05/29 13:09:03 It looks like this bit and related logic can go aw

jochen (gone - plz use gerrit) 2012/05/30 11:28:42 Will upload a separate CL

int render_process_id = -1;

int render_view_id = -1;

if (content::ResourceRequestInfo::GetRenderViewForRequest(